Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Reconsider block weight propagation in loop cloning #103001

Open
amanasifkhalid opened this issue Jun 3, 2024 · 2 comments
Open

JIT: Reconsider block weight propagation in loop cloning #103001

amanasifkhalid opened this issue Jun 3, 2024 · 2 comments
Assignees
@amanasifkhalid
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Priority:2 Work that is important, but not critical for the release
Milestone
9.0.0

Comments

@amanasifkhalid
Copy link
Member

Part of #93020. As mentioned in #102897, the logic in Compiler::optCloneLoops for propagating block weights is probably wrong when we have weights derived from PGO data -- in particular, we shouldn't need to scale weights based on the loop's depth. Doing so likely breaks block weight consistency (which we aren't checking just yet this late in the JIT's phases, hence the lack of assert failures).
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 3, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jun 3, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid amanasifkhalid mentioned this issue Jun 3, 2024
Merged
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Jun 3, 2024
@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Jun 3, 2024
@JulieLeeMSFT JulieLeeMSFT added the Priority:2 Work that is important, but not critical for the release label Jun 3, 2024
@JulieLeeMSFT
Copy link
Member

cc @AndyAyersMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI Priority:2 Work that is important, but not critical for the release
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
2 participants
@amanasifkhalid @JulieLeeMSFT