Add System.Formats.Nrbf to the windowsdesktop transport package #103629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unblocks the windowsdesktop dependency flow. See dotnet/windowsdesktop#4459 (comment)
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
|
@carlossanlop FYI, this change needs to go in before we snap |
|
Thanks for the heads up. Will keep it in mind. The snap is tomorrow Wednesday at 4pm PT. |
ericstj
approved these changes
Jun 18, 2024
|
CI taking more than 4 hours. That's problematic when trying to get changes like this one in. |
you will end up waiting even longer for an official build :( |
|
browser-wasm leg stuck at unlucky build 🥲 |
|
/ba-g we waited long enough and we really need to get this in asap for P6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks the windowsdesktop dependency flow. See dotnet/windowsdesktop#4459 (comment)