Rename StoreVectorMxNAndZip to StoreVectorAndZip

[SwapnilGaikwad]

Partially (item 2) fixes: #102340

[dotnet-issue-labeler]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[dotnet-issue-labeler]

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics
See info in area-owners.md if you want to be subscribed.

[SwapnilGaikwad]

Hi @kunalspathak, the coreclr part of this PR is tested but the mono bit is not. There are two commits separating the coreclr and mono changes that would make it easier to undo/update mono changes if needed.

[kunalspathak]

Added comment to handle it similar to NI_AdvSimd_VectorTableLookup

[kunalspathak]

@fanyang-mono - which CI pipelines we should run to make sure that the code in the PR is getting tested for mono?

[SwapnilGaikwad]

Added comment to handle it similar to NI_AdvSimd_VectorTableLookup

The StoreVectorAndZip is now cleaned-up and matches with VectorTableLookup. On the similar note but unrelated to StoreAndZip - we also got StoreSelectedScalarNxM that can be cleaned-up similarly.
Would you like me to throw those changes in this PR or a separate one?

[kunalspathak]

looks much simpler. Added few last comments.

[kunalspathak]

can you make sure emitSize == EA_8BYTE or emitSize == 16BYTE or do we verify that already by this point?

[SwapnilGaikwad]

Sure, it's asserted in genGetSimdInsOpt() one line 322 above.
We aren't asserting explicitly in other cases, is there a chance getting other values by any chance?
For HW_Category_MemoryStore, the emitSize seemed to be pulled from the table in hwintrinsiclistarm64.h.

[kunalspathak]

yes, that's fine.

[kunalspathak]

Would you like me to throw those changes in this PR or a separate one?

I am ok with either way. Really depends on if you have cycles to do that change here, or later.

[kunalspathak]

LGTM coreclr side

[fanyang-mono]

Test AdvSimd_r.dll passed locally

Supported ISAs:
  AdvSimd:   True
  Aes:       True
  ArmBase:   True
  Crc32:     True
  Dp:        False
  Rdm:       False
  Sha1:      True
  Sha256:    True
  Sve:       False

...

Expected: 100
Actual: 100
END EXECUTION - PASSED

[fanyang-mono]

Mono change looks good to me.

[kunalspathak]

/ba-g failures are known or mono amd64, unrelated