Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: use ValueTask<TItem> in CacheExtensions.GetOrCreateAsync #103666

Closed
gumbarros opened this issue Jun 18, 2024 · 3 comments
Closed

Proposal: use ValueTask<TItem> in CacheExtensions.GetOrCreateAsync #103666

gumbarros opened this issue Jun 18, 2024 · 3 comments
Labels
area-Extensions-Caching question Answer questions and provide assistance, not an issue with source code or documentation.

Comments

@gumbarros
Copy link

Duplicated of #67069

Why is this issue closed? It's marked as completed with no explanation and the method still returns a Task.
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 18, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jun 18, 2024
@vcsjones vcsjones added area-Extensions-Caching and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 18, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-extensions-caching
See info in area-owners.md if you want to be subscribed.

@stephentoub
Copy link
Member

stephentoub commented Jun 18, 2024 •
edited
Loading

Why is this issue closed? It's marked as completed with no explanation and the method still returns a Task.

For the reason cited here:
#67069 (comment)
The existing method's return type can't be changed (it's a binary breaking change) and overloading by return type is not supported. A different name / set of arguments would have been needed to be supplied.

The creator of the issue then closed it.

If you'd like to submit a different proposal, please feel free.

@stephentoub stephentoub added question Answer questions and provide assistance, not an issue with source code or documentation. and removed untriaged New issue has not been triaged by the area owner labels Jun 18, 2024
@stephentoub stephentoub closed this as not planned Won't fix, can't repro, duplicate, stale Jun 18, 2024
@julealgon
Copy link

@gumbarros this has been implemented as part of the new HybridCache coming in .NET 9:

You might want to just switch to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Extensions-Caching question Answer questions and provide assistance, not an issue with source code or documentation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vcsjones @julealgon @stephentoub @gumbarros