Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64/Sve cleanup: Use gtNewSimdCvtMaskToVectorNode from gtFoldExprHWIntrinsic instead of importer #103672

Open
kunalspathak opened this issue Jun 18, 2024 · 1 comment
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support
Milestone

Comments

@kunalspathak
Copy link
Member

Today, during importing we use gtNewSimdCvtMaskToVectorNode to create bigger trees, which can be deferred until gtFoldExprHWIntrinsic.

               [000019] DA-XG------                         ▌  STORE_LCL_VAR simd16<System.Numerics.Vector`1> V01 loc0         
               [000016] ---XG------                         └──▌  HWINTRINSIC simd16 float ConditionalSelect
               [000018] ---XG------                            ├──▌  HWINTRINSIC mask   float ConvertVectorToMask
               [000017] -----------                            │  ├──▌  HWINTRINSIC mask   float CreateTrueMaskAll
               [000009] ---XG------                            │  └──▌  HWINTRINSIC simd16 float ConvertMaskToVector
               [000008] ---XG------                            │     └──▌  HWINTRINSIC mask   float AbsoluteCompareGreaterThan
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 18, 2024
@kunalspathak kunalspathak added arm-sve Work related to arm64 SVE/SVE2 support and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 18, 2024
@kunalspathak kunalspathak self-assigned this Jun 18, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Jun 18, 2024
@jeffschwMSFT jeffschwMSFT added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 19, 2024
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@JulieLeeMSFT JulieLeeMSFT added this to the 9.0.0 milestone Jun 19, 2024
@JulieLeeMSFT JulieLeeMSFT removed the untriaged New issue has not been triaged by the area owner label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support
Projects
None yet
Development

No branches or pull requests

3 participants