Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpListener] contract requires access to internal APIs from Cookie. #19348

Open
Priya91 opened this issue Nov 11, 2016 · 8 comments
Open

[HttpListener] contract requires access to internal APIs from Cookie. #19348

Priya91 opened this issue Nov 11, 2016 · 8 comments
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-System.Net.Http
Milestone

Comments

@Priya91
Copy link
Contributor

Priya91 commented Nov 11, 2016

public sealed class Cookie
{
     internal string ToServerString() { }
     internal CookieVariant Variant { get; }
}

The code is using reflection to get to these values short time, we need alternate solution.

@Priya91
Copy link
Contributor Author

Priya91 commented Nov 11, 2016

cc @CIPop

@karelz
Copy link
Member

karelz commented Feb 28, 2017

@davidsh @Priya91 are we ok shipping current implementation in 2.0?

@karelz
Copy link
Member

karelz commented Feb 28, 2017

cc @geoffkizer

@davidsh
Copy link
Contributor

davidsh commented Feb 28, 2017

@davidsh @Priya91 are we ok shipping current implementation in 2.0?

Fixing this requires adding new API surface to Cookie class. That isn't something we should focus on for 2.0. It would push latest System.Net.Primitives contract out of NS2.0. It's fine for now. We can look more closely at this post 2.0 and possibly iterate the Cookie class API.

@karelz
Copy link
Member

karelz commented Feb 28, 2017

Sounds good, thanks!

@karelz
Copy link
Member

karelz commented Mar 4, 2017

Next step: We need formal API proposal

@hughbe
Copy link
Contributor

hughbe commented May 23, 2017

We also need to expose (in dotnet/corefx#19138 and dotnet/corefx#20167)

public class Cookie
{
    public Cookie Clone() { throw null; }
}

public class CookieCollection
{
    public int InternalAdd(Cookie cookie, bool isStrict) { throw null; }
}

@stephentoub FyI

@caesar-chen caesar-chen changed the title HttpListener contract requires access to internal APIs from Cookie. [HttpListener] contract requires access to internal APIs from Cookie. May 4, 2018
@karelz
Copy link
Member

karelz commented Oct 10, 2019

Triage: Either new API or other solution in HttpListener is needed.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@karelz karelz modified the milestones: 5.0, Future May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-suggestion Early API idea and discussion, it is NOT ready for implementation area-System.Net.Http
Projects
None yet
Development

No branches or pull requests

5 participants