Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetAsync_RequestHeadersAddCustomHeaders_HeaderAndValueSent failing on UAP #22746

Closed
davidsh opened this issue Jul 13, 2017 · 1 comment · Fixed by dotnet/corefx#25052
Closed

GetAsync_RequestHeadersAddCustomHeaders_HeaderAndValueSent failing on UAP #22746

davidsh opened this issue Jul 13, 2017 · 1 comment · Fixed by dotnet/corefx#25052
Assignees
@davidsh
Labels
area-System.Net.Http tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly
Milestone
UWP6.1

Comments

@davidsh
Copy link
Contributor

davidsh commented Jul 13, 2017

The HttpClientHandler test GetAsync_RequestHeadersAddCustomHeaders_HeaderAndValueSent is failing on UAP. It fails when it tries to send a custom header with an empty value:

        public static readonly object[][] HeaderValueAndUris = {
            new object[] { "X-CustomHeader", "x-value", Configuration.Http.RemoteEchoServer },
            new object[] { "X-Cust-Header-NoValue", "" , Configuration.Http.RemoteEchoServer }, // FAILS
            new object[] { "X-CustomHeader", "x-value", Configuration.Http.RedirectUriForDestinationUri(
                secure:false,
                statusCode:302,
                destinationUri:Configuration.Http.RemoteEchoServer,
                hops:1) },
            new object[] { "X-Cust-Header-NoValue", "" , Configuration.Http.RedirectUriForDestinationUri(
                secure:false,
                statusCode:302,
                destinationUri:Configuration.Http.RemoteEchoServer,  // FAILS
                hops:1) },
        };

This is a bug in WinRT HttpClient.

Opened internal bug 12743908
@davidsh davidsh self-assigned this Jul 13, 2017
@davidsh
Copy link
Contributor Author

davidsh commented Nov 3, 2017

Opened internal bug 12743908

This is fixed now in Windows 10 Version 1709 (Build 16299).

davidsh referenced this issue in dotnet/corefx Nov 4, 2017
@davidsh
Cleanup Windows 10 version detection (#25052)
ac41022 
* Cleanup Windows 10 version detection

Windows 10 Version 1709 ("Fall Creators Update") has been released. This
PR cleans up the version detection to use the latest RTM build numbers
and removes obsolete InsiderPreview detection for those tests.

Also, removed ActiveIssue for tests that are now fixed due to Windows 10
fixes.

Fixes #22187

* Addressed feedback
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the UWP6.1 milestone Jan 31, 2020
@sandreenko sandreenko mentioned this issue Feb 12, 2020
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidsh davidsh

Labels
area-System.Net.Http tracking-external-issue The issue is caused by external problem (e.g. OS) - nothing we can do to fix it directly
Projects
None yet
Milestone
UWP6.1
Development

Successfully merging a pull request may close this issue.

Cleanup Windows 10 version detection
2 participants
@davidsh @msftgits