Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Ways to Reduce Dependence on Reflection for EventSource #22793

Open
brianrob opened this issue Jul 17, 2017 · 0 comments
Open

Investigate Ways to Reduce Dependence on Reflection for EventSource #22793

brianrob opened this issue Jul 17, 2017 · 0 comments
Labels
area-System.Diagnostics.Tracing enhancement Product code improvement that does NOT require public API changes/additions
Milestone

Comments

@brianrob
Copy link
Member

EventSources currently require reflection for both manifest-based logging and tracelogging. The latter is required, because there is no concept of subclasses or event methods - just calls to Write public methods on EventSources.

However, we can do better with manifest-based logging. There is currently an IL transform in the toolchain that triggers for a well-known set of EventSources in the framework and pre-generates metadata for them so that reflection is not used at runtime. We should consider expanding this transform for two cases:

  1. Automatically detect reflection blocked types and pre-generate metadata for them, rather than having to explicitly opt the types in.
  2. Support localized resources (the current transform does not support this).
@brianrob brianrob removed their assignment Dec 13, 2017
@ViktorHofer ViktorHofer reopened this Oct 21, 2019
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@tommcdon tommcdon removed the untriaged New issue has not been triaged by the area owner label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Diagnostics.Tracing enhancement Product code improvement that does NOT require public API changes/additions
Development

No branches or pull requests

5 participants