Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate the connection pool code at one location #24808

Closed
saurabh500 opened this issue Jan 26, 2018 · 2 comments
Closed

Consolidate the connection pool code at one location #24808

saurabh500 opened this issue Jan 26, 2018 · 2 comments
Labels
area-System.Data enhancement Product code improvement that does NOT require public API changes/additions

Comments

@saurabh500
Copy link
Contributor

The code for SqlClient and Odbc have duplicated the connection pool code.
This code should be consolidated in the Common folder and a single code base should exist for Connection Pool, the same way .Net framework uses it.
This reduces maintenance cost and code duplication as observed in PR dotnet/corefx#26065

@divega divega changed the title Consolidate the SqlClient and Odbc connection pool code at one location Consolidate the connection pool code at one location May 16, 2019
@divega
Copy link
Contributor

divega commented May 16, 2019

Now that development of SqlClient has moved to its own repo there cannot be source code reuse, but I believe we can keep this issue here since there is still an opportunity for other ways of code reuse across providers in this or other repos.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@ajcvickers ajcvickers added untriaged New issue has not been triaged by the area owner and removed untriaged New issue has not been triaged by the area owner labels Jun 22, 2020
@ajcvickers ajcvickers removed this from the Future milestone Jun 22, 2020
@ajcvickers
Copy link
Member

Covered by #24856.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Data enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

No branches or pull requests

4 participants