Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Xamarin placeholders for System.Memory package #26244

Closed
marek-safar opened this issue May 22, 2018 · 4 comments
Closed

Revert Xamarin placeholders for System.Memory package #26244

marek-safar opened this issue May 22, 2018 · 4 comments

Comments

@marek-safar
Copy link
Contributor

Please revert dotnet/corefx#28034 change, we couldn't get our bits working properly on time for dev15-8 release.

@weshaggard this needs to happen for 4.5 version of System.Memory which I guess is 2.1 release. The fix can stay in master as we'll need it for future versions.

Note: that'll require a better way to coordinate the supported nuget package versions for Xamarin.

It should also address few related issues like aspnet/SignalR#1886

@weshaggard
Copy link
Member

@marek-safar if we do that change will the netstandard asset in the package work correctly on Xamarin? Hopefully it will but I think it is worth validating before we do this change.

@marek-safar
Copy link
Contributor Author

If they work on .net desktop they should

@ahsonkhan
Copy link
Member

cc @joperezr

@tarekgh
Copy link
Member

tarekgh commented Jun 1, 2018

Should be fixed by dotnet/corefx#29925 in release/2.1 branch. Part of 2.1.1 release.

@tarekgh tarekgh closed this as completed Jun 1, 2018
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.x milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants