Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netstandard configuration for System.Security.Cryptography.Pkcs.Tests #27237

Open
ViktorHofer opened this issue Aug 26, 2018 · 5 comments
Open
Labels
area-System.Security test-enhancement Improvements of test source code
Milestone

Comments

@ViktorHofer
Copy link
Member

Currently we don't test the netstandard implementation but only netcoreapp and netfx. For https://github.com/dotnet/corefx/issues/25083 we should add it.

I tried it myself but as some failure popped up I reverted my changes and created this issue.

@filipnavara
Copy link
Member

Out of curiosity, do you still have the code that resulted in failure? I have some pending patches for that library and I may take up on this issue as well.

@ViktorHofer
Copy link
Member Author

That's pretty easy to reproduce. Remove the netfx configuration and replace it with netstandard in Configurations.props and in the test.csproj and then run the tests dotnet msbuild /t:RebuildAndTest /p:TargetGroup=netfx.

@ViktorHofer
Copy link
Member Author

@bartonjs
Copy link
Member

bartonjs commented Jul 5, 2019

@ViktorHofer It looks like since this was opened we added, then removed, a netstandard configuration in Configurations.props. We're still in the state that we don't have a way to test the netstandard libs in this package, though.

Is there anything that we should still do here?

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Jul 5, 2019

The netcoreapp and netstandard(2.1) configurations seem to be identical, still we should test both of them. We could try to enable the tests on UAP which would pick the netstandard one.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the Future milestone Jan 31, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@bartonjs bartonjs removed the untriaged New issue has not been triaged by the area owner label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Security test-enhancement Improvements of test source code
Projects
None yet
Development

No branches or pull requests

5 participants