System.Runtime.CompilerServices.Unsafe binding redirect missing when also referencing System.IO.Pipelines

[AArnott]

When referencing the latest System.IO.Pipelines and System.Runtime.CompilerServices.Unsafe packages from a net46 application, the binding redirects required at runtime are not generated automatically, resulting in runtime failure:

Repro

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net46</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="system.IO.Pipelines" Version="4.5.3" />
    <!--<PackageReference Include="System.Memory" Version="4.5.2" />-->
    <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="4.5.2" />
  </ItemGroup>
</Project>

using System;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;

class Program
{
    static void Main(string[] args)
    {
        byte[] buffer = new byte[4];
        int value = Unsafe.ReadUnaligned<int>(ref MemoryMarshal.GetReference(buffer.AsSpan()));
    }
}

Unhandled Exception: System.IO.FileLoadException: Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=4.0.4.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
at System.Span`1..ctor(T[] array)
at System.MemoryExtensions.AsSpan[T](T[] array)
at Program.Main(String[] args)

When uncommenting the System.Memory PackageReference in the project file in the above repro, the problem goes away. I believe this has already been fixed in the latest System.Memory package. The problem is that the latest System.IO.Pipelines package refers to an older version of System.Memory that does not include the fix.

Similar to #27492

[davidfowl]

cc @ericstj any ideas?

[ericstj]

When a package is update to fix a servicing issue we don't update every package that references it. What happens if you reference the latest pre-release package out of master?

[davidfowl]

Is there anything to do here?

[ericstj]

It may have been fixed in with the latest baselining that @joperezr did in master. @AArnott does it still repro in the latest packages?

[AArnott]

The versions in the repro are still the latest (stable) packages. Did you want me to test the preview packages that have been pushed to nuget?

[AArnott]

Using the latest preview packages, the problem still repros.

    <PackageReference Include="system.IO.Pipelines" Version="4.6.0-preview5.19224.8" />
    <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="4.6.0-preview6.19259.10" />

[ericstj]

That's not latest. Why are you not using a preview6 build for pipelines? Looks like Nuget.org only has preview 5. Can you grab the latest off of https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json.

[ericstj]

Worked for me when referencing

    <PackageReference Include="System.IO.Pipelines" Version="4.6.0-preview7.19310.3" />
    <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="4.6.0-preview7.19310.3" />

@AArnott please give a try and close if you're fixed.

[ericstj]

Or if you prefer Preview6 (upcoming release):

    <PackageReference Include="System.IO.Pipelines" Version="4.6.0-preview6.19303.8" />
    <PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="4.6.0-preview6.19303.8" />

I found that the 4.6.0-preview6.19259.10 version of Unsafe was a one-off build out of master that isn't a complete set of packages.

[AArnott]

Yes, with 4.6.0-preview6.19303.8 it works. Thanks.