Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Utf8Parser date helpers to static helper class #28931

Open
layomia opened this issue Mar 11, 2019 · 3 comments
Open

Extract Utf8Parser date helpers to static helper class #28931

layomia opened this issue Mar 11, 2019 · 3 comments
Labels
area-System.Memory help wanted [up-for-grabs] Good issue for external contributors
Milestone

Comments

@layomia
Copy link
Contributor

layomia commented Mar 11, 2019

The DateTime(Offset) parsing logic in Utf8JsonReader (dotnet/corefx#35903) depends on copied implementations of these helpers. Extracting them would remove this duplication.

@karelz
Copy link
Member

karelz commented Mar 29, 2019

@layomia please only 1 area label - here's why: https://github.com/dotnet/corefx/blob/master/Documentation/project-docs/issue-guide.md#triage-rules---simplified
@joshfree FYI we do not use assignments, unless people are actively working on issues ... (see above)

@joshfree
Copy link
Member

Marking this as up-for-grabs

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the Future milestone Feb 1, 2020
@ViktorHofer
Copy link
Member

@layomia I know about people being interested in helping out with up-for-grabs issues. Can you please check if this is still todo and if yes provide some basic steps how to tackle the issue? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Memory help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

No branches or pull requests

5 participants