Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uri] Rewrite UriHelper.UnescapeString to remove unsafe code and improve perf #31173

Open
stephentoub opened this issue Oct 15, 2019 · 0 comments
Open

[Uri] Rewrite UriHelper.UnescapeString to remove unsafe code and improve perf #31173

stephentoub opened this issue Oct 15, 2019 · 0 comments
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions
Milestone
Future

Comments

@stephentoub
Copy link
Member

PR dotnet/corefx#41772 rewrote EscapeString with safe code, and it not only removed unsafe code from a key networking-exposed area of the system, it also resulting in performance benefits and cleaner code. We should look at doing the same thing for the other direction with UnescapeString. It's likely to be a bit more challenging, as it currently has more modes for configuration.
@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 5.0 milestone Feb 1, 2020
@MihaZupan MihaZupan changed the title Rewrite UriHelper.UnescapeString to remove unsafe code and improve perf [Uri] Rewrite UriHelper.UnescapeString to remove unsafe code and improve perf Apr 12, 2020
@karelz karelz modified the milestones: 5.0, Future May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@stephentoub @karelz @msftgits