Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in System.Tests.Perf_String.ToLowerInvariant #31453

Closed
DrewScoggins opened this issue Nov 9, 2019 · 5 comments
Closed

Regression in System.Tests.Perf_String.ToLowerInvariant #31453

DrewScoggins opened this issue Nov 9, 2019 · 5 comments
Labels
area-System.Runtime tenet-performance-benchmarks Issue from performance benchmark
Milestone
Future

Comments

@DrewScoggins
Copy link
Member

There is a regression of 138% in System.Tests.Perf_String.ToLowerInvariant(s: "TEST") between 3.0->3.1.

image
@DrewScoggins
Copy link
Member Author

We are also seeing a 28% regression in System.Tests.Perf_String.ToLower(s: "TEST").

image

@danmoseley
Copy link
Member

Is it possible to better localize the point of regression?

@DrewScoggins
Copy link
Member Author

This test has shown a regression from the first run of our tests on this branch on 9/20 two days after the baseline 3.0 was run.

The builds you can use for comparison are in core-sdk and:

baseline: 04339c3a262a2e313f9431edd3805ce71e08b92e
compare: abd1e70d5fb3f8ef82f41d308f089c68e072ff4d

@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 23, 2020
@danmoseley
Copy link
Member

@DrewScoggins is this issue still relevant/useful? Should we track everytihng in #37816?

@joperezr joperezr added this to the Future milestone Jul 7, 2020
@joperezr joperezr removed the untriaged New issue has not been triaged by the area owner label Jul 7, 2020
@DrewScoggins
Copy link
Member Author

Yeah, we should close this and do the tracking in the other bug.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Runtime tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
Future
Development

No branches or pull requests
5 participants
@maryamariyan @danmoseley @ericstj @DrewScoggins @joperezr