Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUIC] Update MsQuic GCHandles #31695

Closed
scalablecory opened this issue Feb 4, 2020 · 2 comments
Closed

[QUIC] Update MsQuic GCHandles #31695

scalablecory opened this issue Feb 4, 2020 · 2 comments
Assignees
@ManickaP
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions tenet-reliability Reliability/stability related issue (stress, load problems, etc.)
Projects
HTTP/3
Milestone
6.0.0

Comments

@scalablecory
Copy link
Contributor

Some of the classes in MsQuic implementation are allocating a GCHandle for this and is depending on Dispose or finalizer to deallocate this. If a user forgets to call Dispose, the GC will never collect the object due to the GCHandle.
@scalablecory scalablecory added this to the 5.0 milestone Feb 4, 2020
@scalablecory scalablecory added this to To Do in HTTP/3 via automation Feb 4, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 4, 2020
@scalablecory scalablecory moved this from To Do (Low Priority) to To Do (High Priority) in HTTP/3 Feb 10, 2020
@scalablecory scalablecory removed the untriaged New issue has not been triaged by the area owner label Feb 10, 2020
@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions tenet-reliability Reliability/stability related issue (stress, load problems, etc.) labels Feb 20, 2020
@karelz karelz changed the title Update MsQuic GCHandles [QUIC] Update MsQuic GCHandles Mar 11, 2020
@scalablecory
Copy link
Contributor Author

@geoffkizer feel free to unassign if you won't be able to get to this. We could reasonably bump this to 6.0 if we need to.

@karelz karelz modified the milestones: 5.0.0, 6.0.0 Aug 18, 2020
@scalablecory scalablecory self-assigned this Nov 12, 2020
@karelz karelz mentioned this issue Feb 4, 2021
Closed
28 tasks
@ManickaP ManickaP moved this from To Do (High Priority) to In Progress in HTTP/3 Mar 17, 2021
@ManickaP ManickaP assigned ManickaP and unassigned scalablecory Mar 17, 2021
@ManickaP ManickaP mentioned this issue Mar 18, 2021
Merged
@ManickaP
Copy link
Member

ManickaP commented Apr 6, 2021

Close by #49823

@ManickaP ManickaP closed this as completed Apr 6, 2021
HTTP/3 automation moved this from In Progress to Done Apr 6, 2021
@dotnet dotnet locked as resolved and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ManickaP ManickaP

Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions tenet-reliability Reliability/stability related issue (stress, load problems, etc.)
Projects
No open projects
HTTP/3
  
Done
Milestone
6.0.0
Development

No branches or pull requests
5 participants
@scalablecory @karelz @ManickaP @geoffkizer @Dotnet-GitSync-Bot