Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QUIC] Use shared SocketAddress code in QUIC #32068

Closed
scalablecory opened this issue Feb 10, 2020 · 1 comment · Fixed by #66794
Closed

[QUIC] Use shared SocketAddress code in QUIC #32068

scalablecory opened this issue Feb 10, 2020 · 1 comment · Fixed by #66794
Assignees
@rzikm
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
HTTP/3
Milestone
7.0.0

Comments

@scalablecory
Copy link
Contributor

Instead of reimplementing sockaddr serialization, we should use the existing EndPoint -> SocketAddress -> byte[] logic in System.Net.Primitives.

runtime/src/libraries/System.Net.Quic/src/System/Net/Quic/Implementations/MsQuic/Internal/MsQuicAddressHelpers.cs

Lines 27 to 31 in 5c6f5b1

internal static SOCKADDR_INET IPEndPointToINet(IPEndPoint endpoint)
{
SOCKADDR_INET socketAddress = default;
byte[] buffer = endpoint.Address.GetAddressBytes();
if (endpoint.Address != IPAddress.Any && endpoint.Address != IPAddress.IPv6Any)

@scalablecory scalablecory added this to the 5.0 milestone Feb 10, 2020
@scalablecory scalablecory added this to To Do (Low Priority) in HTTP/3 via automation Feb 10, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Feb 10, 2020
@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner labels Feb 21, 2020
@karelz karelz modified the milestones: 5.0, Future Feb 21, 2020
@karelz karelz changed the title Use shared SocketAddress code in QUIC [QUIC] Use shared SocketAddress code in QUIC Mar 11, 2020
@scalablecory scalablecory modified the milestones: Future, 6.0.0 Aug 11, 2020
@karelz karelz mentioned this issue Feb 4, 2021
Closed
28 tasks
@karelz karelz modified the milestones: 6.0.0, Future May 18, 2021
@karelz karelz moved this from To Do (Low Priority) to Future in HTTP/3 May 18, 2021
@samsp-msft samsp-msft mentioned this issue Aug 17, 2021
Closed
28 tasks
@karelz karelz modified the milestones: Future, 7.0.0 Oct 26, 2021
@karelz karelz moved this from Future to To Do (Low Priority) in HTTP/3 Oct 26, 2021
@karelz
Copy link
Member

karelz commented Oct 26, 2021

Triage: We should clean it up, unless it is high cost.

@rzikm rzikm self-assigned this Mar 17, 2022
@rzikm rzikm mentioned this issue Mar 17, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Mar 17, 2022
HTTP/3 automation moved this from To Do (Low Priority) to Done Mar 30, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Mar 30, 2022
@dotnet dotnet locked as resolved and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzikm rzikm

Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
No open projects
HTTP/3
  
Done
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Use shared SocketAddress code in QUIC rzikm/dotnet-runtime
5 participants
@scalablecory @karelz @geoffkizer @rzikm @Dotnet-GitSync-Bot