Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Extensions.Http test failure on mono #34023

Closed
maryamariyan opened this issue Mar 24, 2020 · 7 comments
Closed

Microsoft.Extensions.Http test failure on mono #34023

maryamariyan opened this issue Mar 24, 2020 · 7 comments
Labels
area-Extensions-HttpClientFactory blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' runtime-mono specific to the Mono runtime
Milestone

Comments

@maryamariyan
Copy link
Member

maryamariyan commented Mar 24, 2020

This issue tracks Http test failing on Mono:

Microsoft.Extensions.Http.DefaultHttpClientFactoryTest.Factory_CleanupCycle_DisposesLiveHandler

https://helix.dot.net/api/2019-06-17/jobs/c6ed46b1-0512-4f5d-b721-ecaaaa01dc59/workitems/Microsoft.Extensions.Http.Tests/console

Discovering: Microsoft.Extensions.Http.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  Microsoft.Extensions.Http.Tests (found 70 test cases)
  Starting:    Microsoft.Extensions.Http.Tests (parallel test collections = on, max threads = 2)
    Microsoft.Extensions.Http.DefaultHttpClientFactoryTest.Factory_CleanupCycle_DisposesLiveHandler [FAIL]
      Cleanup entry disposable
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/Microsoft.Extensions.Http/tests/DefaultHttpClientFactoryTest.cs(449,0): at Microsoft.Extensions.Http.DefaultHttpClientFactoryTest.Factory_CleanupCycle_DisposesLiveHandler()
        --- End of stack trace from previous location ---
  Finished:    Microsoft.Extensions.Http.Tests
@safern
Copy link
Member

safern commented Mar 24, 2020

Added console output to description since the file links might expire.

@danmoseley danmoseley added the runtime-mono specific to the Mono runtime label Mar 25, 2020
@danmoseley
Copy link
Member

@maryamariyan there is a label runtime-mono that is handy for mono specific issues

@danmoseley
Copy link
Member

Likely relates to different GC behavior on Mono. Test says "depends on the GC and timing."

@maryamariyan maryamariyan added this to Untriaged-NoMilestone in ML, Extensions, Globalization, etc, POD. via automation Jun 18, 2020
@maryamariyan maryamariyan removed the untriaged New issue has not been triaged by the area owner label Jun 18, 2020
@maryamariyan maryamariyan added this to the Future milestone Jun 18, 2020
@maryamariyan maryamariyan removed this from Untriaged-NoMilestone in ML, Extensions, Globalization, etc, POD. Jun 18, 2020
@jkotas
Copy link
Member

jkotas commented Jul 22, 2020

Failed in #39717

@jkotas jkotas added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Jul 22, 2020
@danmoseley
Copy link
Member

@maryamariyan please fix or disable

@akoeplinger
Copy link
Member

@maryamariyan I think this is the result of different GC on Mono, we disabled some similar tests with the PlatformDetection.IsPreciseGcSupported which returns false on Mono. The same should be done with this test.

@directhex
Copy link
Member

Closing the issue, since the test in question is now annotated with IsPreciseGcSupported. If Mono ever supports that, we can revisit related issues.

Getting libraries tests passing on Mono/devices automation moved this from To do to Done Sep 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
@karelz karelz modified the milestones: Future, 5.0.x May 20, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-HttpClientFactory blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' runtime-mono specific to the Mono runtime
Development

No branches or pull requests

8 participants