Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching.Memory tests are impacting CI reliability #34128

Closed
jaredpar opened this issue Mar 26, 2020 · 3 comments
Closed

Caching.Memory tests are impacting CI reliability #34128

jaredpar opened this issue Mar 26, 2020 · 3 comments
Assignees
Labels
area-Extensions-Caching blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' test-bug Problem in test source code (most likely) untriaged New issue has not been triaged by the area owner

Comments

@jaredpar
Copy link
Member

Several tests in this group are failing. Looks like some inherent flakiness here that needs to be addressed:

  • Microsoft.Extensions.Caching.Memory.MemoryCacheSetAndRemoveTests.GetAndSet_AreThreadSafe_AndUpdatesNeverLeavesNullValues
  • Microsoft.Extensions.Caching.Memory.MemoryCacheSetAndRemoveTests.GetAndSet_AreThreadSafe_AndUpdatesNeverLeavesNullValues
  • Microsoft.Extensions.Caching.Memory.CapacityTests.ExpiringEntryDecreasesCacheSize

Console Log Summary

Assert.False() Failure\nExpected: False\nActual: True

Stack trace
   at Microsoft.Extensions.Caching.Memory.MemoryCacheSetAndRemoveTests.GetAndSet_AreThreadSafe_AndUpdatesNeverLeavesNullValues() in /_/src/libraries/Microsoft.Extensions.Caching.Memory/tests/MemoryCacheSetAndRemoveTests.cs:line 489

Builds

Build Pull Request Test Failure Count
#573475 #33984 1
#574007 #34107 1
#574039 Rolling 1
#574145 #34113 1
#574187 Rolling 2
#574195 #32592 3
#574272 #32107 1
#574310 Rolling 3
#574321 #32592 1
#574382 #34061 1

Configurations

  • netcoreapp5.0-Linux-Debug-x64-CoreCLR_release-Debian.9.Amd64.Open
  • netcoreapp5.0-Linux-Debug-x64-Mono_release-SLES.15.Amd64.Open
  • netcoreapp5.0-Linux-Release-arm64-CoreCLR_release-(Alpine.38.Arm64.Open)Ubuntu.1804.ArmArch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.8-helix-arm64v8-a45aeeb-20190620184035
  • netcoreapp5.0-Linux-Release-arm64-CoreCLR_release-(Ubuntu.1804.ArmArch.Open)Ubuntu.1804.ArmArch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-16.04-helix-arm64v8-bfcd90a-20200127194925
  • netcoreapp5.0-Linux-Release-x64-CoreCLR_release-Debian.9.Amd64.Open
  • netcoreapp5.0-Windows_NT-Debug-x64-Mono_release-(Windows.Nano.1809.Amd64.Open)windows.10.amd64.serverrs5.open@mcr.microsoft.com/dotnet-buildtools/prereqs:nanoserver-1809-helix-amd64-08e8e40-20200107182504
  • netcoreapp5.0-Windows_NT-Debug-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
  • netcoreapp5.0-Windows_NT-Release-x86-CoreCLR_checked-Windows.10.Amd64.Open
  • netcoreapp5.0-Windows_NT-Release-x86-CoreCLR_release-Windows.10.Amd64.Server19H1.Open
  • netcoreapp5.0-Windows_NT-Release-x86-CoreCLR_release-Windows.10.Amd64.ServerRS5.Open

Helix Logs

Build Pull Request Console Core Test Results
#573475 #33984 console.d2783e41.log testResults.xml
#574007 #34107 console.dfed949a.log
#574039 Rolling console.5888d78a.log
#574145 #34113 console.ed98370f.log testResults.xml
#574187 Rolling console.18e09cc6.log testResults.xml
#574187 Rolling console.c15c1d96.log testResults.xml
#574195 #32592 console.8de44599.log testResults.xml
#574195 #32592 console.6bef8943.log testResults.xml
#574195 #32592 console.b749e716.log
#574272 #32107 console.ad9f0b28.log testResults.xml
#574310 Rolling console.d7ef0d51.log
#574310 Rolling console.b7698877.log testResults.xml
#574310 Rolling console.685207a6.log
#574321 #32592 console.1b681dda.log
#574382 #34061 console.a5a81439.log
@jaredpar jaredpar added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' intermittent labels Mar 26, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-Infrastructure-coreclr untriaged New issue has not been triaged by the area owner labels Mar 26, 2020
@ericstj
Copy link
Member

ericstj commented Mar 26, 2020

@maryamariyan can we disable these tests and file an issue? (or fix the tests or product if the bug is straightforward)

@ericstj ericstj added area-Microsoft.Extensions test-bug Problem in test source code (most likely) and removed area-Infrastructure-coreclr labels Mar 26, 2020
@maryamariyan
Copy link
Member

I spotted one of them yesterday on the CI PR that were failing on Mono so I created this issue for it:
#33993.

Thanks seems like it is not necessarily a Mono flakiness. I'll update that issue and push a PR

@ericstj
Copy link
Member

ericstj commented Mar 26, 2020

Dup of #33993

@ericstj ericstj closed this as completed Mar 26, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Extensions-Caching blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' test-bug Problem in test source code (most likely) untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

4 participants