Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding Vector64<double>.CreateScalar, Vector64<ulong>CreateScalar and Vector64<long>.CreateScalar or renaming Create #34929

Closed
echesakov opened this issue Apr 14, 2020 · 2 comments · Fixed by #38139
Assignees
Labels
api-approved API was approved in API review, it can be implemented arch-arm64 area-System.Runtime.Intrinsics
Milestone

Comments

@echesakov
Copy link
Contributor

We should probably either add these methods to be consistent with other types or rename existing Create methods that accept double, long and ulong to CreateScalar since we usually append suffix Scalar to the name of the methods operating on or returning Vector64<double>, Vector64<long> or Vector64<ulong>.

public static unsafe Vector64<double> CreateScalar(double value);
public static unsafe Vector64<long>   CreateScalar(long value);
public static unsafe Vector64<ulong>  CreateScalar(ulong value);
@ghost
Copy link

ghost commented Apr 14, 2020

Tagging subscribers to this area: @tannergooding
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Apr 14, 2020
@BruceForstall BruceForstall added this to To do general in Hardware Intrinsics via automation Apr 16, 2020
@BruceForstall BruceForstall added this to the 5.0 milestone Apr 16, 2020
@BruceForstall BruceForstall moved this from To do general to To do arm64 in Hardware Intrinsics Apr 16, 2020
@tannergooding tannergooding removed the untriaged New issue has not been triaged by the area owner label Apr 16, 2020
@BruceForstall BruceForstall moved this from To do arm64 to API design in Hardware Intrinsics Apr 16, 2020
@terrajobst terrajobst added api-approved API was approved in API review, it can be implemented and removed api-ready-for-review labels May 5, 2020
@terrajobst
Copy link
Member

terrajobst commented May 5, 2020

Video

  • Looks good as proposed
namespace System.Runtime.Intrinsics
{
    public partial class Vector64
    {
        public static unsafe Vector64<double> CreateScalar(double value);
        public static unsafe Vector64<long>   CreateScalar(long value);
        public static unsafe Vector64<ulong>  CreateScalar(ulong value);
    }
}

@echesakov echesakov moved this from API design to In progress in Hardware Intrinsics May 6, 2020
@echesakov echesakov self-assigned this May 6, 2020
@echesakov echesakov moved this from In progress to To do arm64 in Hardware Intrinsics May 6, 2020
@echesakov echesakov moved this from To do arm64 to In progress in Hardware Intrinsics Jun 15, 2020
Hardware Intrinsics automation moved this from In progress to Done Jun 22, 2020
@dotnet dotnet locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api-approved API was approved in API review, it can be implemented arch-arm64 area-System.Runtime.Intrinsics
Projects
5 participants