System.Private.Uri.Functional.Tests crashes on tvOS #36891
Comments
Dotnet-GitSync-Bot
added
the
untriaged
steveisok
moved this from To do
to Apple ToDo
in Getting libraries tests passing on Mono/devices
|
Tagging subscribers to this area: @dotnet/ncl |
|
Per https://github.com/dotnet/runtime/blob/master/docs/area-owners.md, URI is area-System.Net |
|
may be lack of globalization. #33652 |
|
This test should come down to string.Compare(
"http://www.contoso.com/path?name#frag",
"http://www.contosooo.com/pathname#slag",
StringComparison.CurrentCulture)So a globalization issue as Tomas suggested |
|
OK, adjusting label to match responsibility. |
|
@MihaZupan does this issue repo only on iOS? and succeed on other platforms? why the test is using the current culture for the uri comparison? I am seeing you can have this assumption to all cultures return the exact same string comparing results. I am seeing this is a test issue more than the Globalization issue. |
|
Tagging subscribers to this area: @dotnet/ncl |
|
I haven't seen this test come up before. There's also no reason for it to use CurrentCulture - we can fix that in the test. I don't know under which culture this was triggered, @mdh1418 do you have a way to obtain that information? It does not fail under any installed culture on my Windows machine. |
|
I would say do a quick try to change current culture to CultureInfo.InvariantCulture and look if the test fail at that time. |
|
I don't have a way to test if the behavior is any different on iOS specifically |
just get the current culture from the iOS (using CultureInfo.CurrentCulture) and then use the exact same culture in other platforms and look at what you will get from the test result. |
|
I think there might be a misunderstanding here - I did not run these tests. Afaik iOS is not available in Helix yet for me to be able to repro this. |
no misunderstanding, we need just ask @mdh1418 to get the needed info from iOS run as he is the one reported the issue. |
|
Yeah, there is no helix iOS runs yet. We're just opening issues at the moment to be able to disable them, get clean runs and then be able to enable helix runs. |
|
I have setup where I can run iOS tests @MihaZupan. I droped investigations since it did not seems high priority for .NET 5. There seems to be fair amount of test failing around string processing in various test sets. I can give it try with the proposed change later this week so we get at least some insight. |
|
Sorry for the noise/confusion. As per email I sent a couple weeks back, please ignore all issues for os-iOS, os-Android, and os-tvOS for now. Folks in the Mono team, and @safern, are working on getting this test pass rate up. In this case, it is very likely just one fallout of a larger problem with ICU on iOS. |
mdh1418
changed the title
|
@mdh1418 These tests pass and can be enabled again. |
|
It looks like this suite is not disabled in tests.proj, and there doesn't seem to be any occurrence of the issue number in the codebase |
ghost
locked as resolved and limited conversation to collaborators
Update: This suite no longer fails on iOS, but crashes on tvOS
System.Private.Uri.Functional.Tests crashes on tvOS
The text was updated successfully, but these errors were encountered: