Failed to check CMake version

[xiangzhai]

Hi,

Description

When building coreclr:

./src/coreclr/build-runtime.sh

check_prereqs failed to check CMake version:

Commencing CoreCLR Repo build
__DistroRid: linux-mips64
__RuntimeId: linux-mips64
Setting up directories for build
Checking prerequisites...
/usr/bin/cmake
Found cmake v in PATH. Please install v3.14.5 or newer from https://www.cmake.org/download/.

Because cmake --version is:

cmake version 3.16.20191127-g7046a52

CMake suite maintained and supported by Kitware (kitware.com/cmake).

Workaround patch:

diff --git a/eng/native/build-commons.sh b/eng/native/build-commons.sh
index 31d8d8b..735a090 100755
--- a/eng/native/build-commons.sh
+++ b/eng/native/build-commons.sh
@@ -54,7 +54,7 @@ check_prereqs()
     function version { echo "$@" | awk -F. '{ printf("%d%02d%02d\n", $1,$2,$3); }'; }
 
     local cmakeRequiredMinimumVersion="3.14.5"
-    local cmakeInstalledVersion="$(cmake --version | awk '/^cmake.* version [0-9]+\.[0-9]+\.[0-9]+$/ {print $3}')"
+    local cmakeInstalledVersion="$(cmake --version 2>&1 | sed '1!d' | sed -e 's/"//g' | awk '{print $3}')"
 
     if [[ "$(version "$cmakeInstalledVersion")" -lt "$(version "$cmakeRequiredMinimumVersion")" ]]; then
         echo "Found cmake v$cmakeInstalledVersion in PATH. Please install v$cmakeRequiredMinimumVersion or newer from https://www.cmake.org/download/."

Thanks,
Leslie Zhai

[BruceForstall]

@xiangzhai Looks ok to me. presumably it will compare "3.14.5" against "3.16.20191127-g7046a52" which will do the right thing?

Can you submit a PR?

[xiangzhai]

Hi @BruceForstall

Can you submit a PR?

#37398

Thanks,
Leslie Zhai

[jashook]

Addressed