Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex.Match parameter name "startat" should be camel case #39518

Closed
cesarsouza opened this issue Jul 17, 2020 · 4 comments
Closed

Regex.Match parameter name "startat" should be camel case #39518

cesarsouza opened this issue Jul 17, 2020 · 4 comments
Labels
area-System.Text.RegularExpressions untriaged New issue has not been triaged by the area owner

Comments

@cesarsouza
Copy link

Hi,

Currently, the parameters of Regex.Match(string, int) are called "input" and "startat". Shouldn't the latter be named "startAt" to match the rest of the framework's naming conventions?

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Text.RegularExpressions untriaged New issue has not been triaged by the area owner labels Jul 17, 2020
@ghost
Copy link

ghost commented Jul 17, 2020

Tagging subscribers to this area: @eerhardt, @pgovind
Notify danmosemsft if you want to be subscribed.

@Gnbrkm41
Copy link
Contributor

Wouldn't it be a breaking change for those who use named parameters?

@danmoseley
Copy link
Member

Yes it would be a breaking change and this is why we are stuck with it. Thanks for the suggestion.

@danmoseley
Copy link
Member

by the way @cesarsouza , perhaps you'd be interested in contributing to the repo? we have many possibilities -- https://github.com/dotnet/runtime/issues?q=is%3Aopen+is%3Aissue+label%3Aup-for-grabs

Let me know if you have interest and I can provide any help.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.RegularExpressions untriaged New issue has not been triaged by the area owner
Projects
None yet
Development

No branches or pull requests

4 participants