Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpTelemetry instrumentation for HTTP/3 #40896

Closed
MihaZupan opened this issue Aug 16, 2020 · 3 comments · Fixed by #65644
Closed

HttpTelemetry instrumentation for HTTP/3 #40896

MihaZupan opened this issue Aug 16, 2020 · 3 comments · Fixed by #65644
Assignees
@MihaZupan
Labels
area-System.Net.Http
Projects
HTTP/3
Milestone
7.0.0

Comments

@MihaZupan
Copy link
Member

MihaZupan commented Aug 16, 2020 •
edited
Loading

Newly added System.Net.Http Telemetry should be expanded to HTTP/3 in the future.

Currently, only the Start/Failed/Stop events are available for HTTP/3.
@MihaZupan MihaZupan added this to the Future milestone Aug 16, 2020
@ghost
Copy link

ghost commented Aug 16, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Aug 16, 2020
@MihaZupan MihaZupan removed the untriaged New issue has not been triaged by the area owner label Aug 16, 2020
@MihaZupan MihaZupan mentioned this issue Aug 16, 2020
Merged
@ManickaP ManickaP mentioned this issue Aug 28, 2020
Merged
@ManickaP ManickaP added this to To Do (Low Priority) in HTTP/3 via automation Mar 4, 2021
@karelz karelz moved this from To Do (Low Priority) to Future in HTTP/3 May 18, 2021
@karelz karelz modified the milestones: Future, 7.0.0 Oct 26, 2021
@karelz karelz moved this from Future to To Do (Low Priority) in HTTP/3 Oct 26, 2021
@karelz karelz moved this from To Do (Low Priority) to To Do (High Priority) in HTTP/3 Oct 26, 2021
@MihaZupan
Copy link
Member Author

@ManickaP @CarnaViire Are there any major code changes planned for HTTP/3 during 7.0 that would be complicated if telemetry code were in place already?
I'm happy to do the change as long as it doesn't cause you more work in the long run.

@ManickaP
Copy link
Member

No major changes planned. There might be some perf work around stream data handling, like: #58445.
I don't think adding telemetry now will cause more work for us in the future. Feel free to tackle this and thanks for taking the initiative here!

@MihaZupan MihaZupan self-assigned this Feb 18, 2022
@MihaZupan MihaZupan mentioned this issue Feb 21, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 21, 2022
HTTP/3 automation moved this from To Do (High Priority) to Done Feb 23, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MihaZupan MihaZupan

Labels
area-System.Net.Http
Projects
No open projects
HTTP/3
  
Done
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Implement HttpTelemetry for HTTP/3 MihaZupan/runtime
4 participants
@karelz @ManickaP @MihaZupan @Dotnet-GitSync-Bot