Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use internal versions of linker dynamic attributes in multi-TFM libraries #40999

Closed
layomia opened this issue Aug 18, 2020 · 1 comment
Closed

Use internal versions of linker dynamic attributes in multi-TFM libraries #40999

layomia opened this issue Aug 18, 2020 · 1 comment
Assignees
@layomia
Labels
area-System.Text.Json linkable-framework Issues associated with delivering a linker friendly framework
Milestone
5.0.0

Comments

@layomia
Copy link
Contributor

layomia commented Aug 18, 2020

Recent work to annotate multi-TFM libraries for linker safety has introduced netcoreapp specific #ifdefs in ref assemblies, e.g. in System.Text.Json, in order to use DynamicallyAccessedMembersAttribute and DynamicallyAccessedMemberTypes which are netcoreapp only. From previous discussions on keeping support for netstandard2.0 TFMs, whenever we have a situation that requires adding #ifdefs in the ref, it introduces increased complexity in maintaining support for ns2.0.

Similar to the approach for Nullable and the Microsoft.Extension libraries, the action for 5.0 is to use internal versions of the attributes as a dependency on each applicable library.

cc @eerhardt @joperezr @ericstj
fyi @ahsonkhan
@layomia layomia added area-Meta linkable-framework Issues associated with delivering a linker friendly framework labels Aug 18, 2020
@layomia layomia added this to the 5.0.0 milestone Aug 18, 2020
@layomia layomia self-assigned this Aug 18, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Aug 18, 2020
@joperezr joperezr removed the untriaged New issue has not been triaged by the area owner label Aug 24, 2020
@layomia layomia mentioned this issue Aug 27, 2020
Merged
@github-actions github-actions bot mentioned this issue Aug 28, 2020
Merged
@layomia
Copy link
Contributor Author

layomia commented Aug 28, 2020

Fixed in #41490.

@layomia layomia closed this as completed Aug 28, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@layomia layomia

Labels
area-System.Text.Json linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
3 participants
@layomia @joperezr @Dotnet-GitSync-Bot