Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/5.0 - Update SDK to final P8/RC1 #41684

Closed
ViktorHofer opened this issue Sep 1, 2020 · 10 comments
Closed

release/5.0 - Update SDK to final P8/RC1 #41684

ViktorHofer opened this issue Sep 1, 2020 · 10 comments

Comments

@ViktorHofer
Copy link
Member

ViktorHofer commented Sep 1, 2020

We are currently using a non-final P8 SDK in release/5.0. We should update to a final P8/RC1 SDK at some point.

To consume the RC1 SDK, the following changes are necessary:

We should do the same change in master but as it impacts more developers, it should be done as part of a batched rollout (ideally next week's one).

cc @dotnet/runtime-infrastructure

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Sep 1, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ericstj ericstj added area-Infrastructure and removed untriaged New issue has not been triaged by the area owner labels Sep 1, 2020
@ghost
Copy link

ghost commented Sep 1, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@ViktorHofer
Copy link
Member Author

We believe this isn't necessary for shipping the product but we should do it anyway to minimize servicing diffs when taking a dependency on a serviced SDK.

@jkotas
Copy link
Member

jkotas commented Sep 15, 2020

The release branch is building with Roslyn pinned to one of the preview versions. #42174 unpinned compiler in the master branch. Include this change in this port?

@ViktorHofer
Copy link
Member Author

Our plan was to work on this post RTM before the first servicing release. Is there risk involved with keeping the existing pinned compiler? If yes, I could prepare a PR today to make this ready for RC2.

@jkotas
Copy link
Member

jkotas commented Sep 15, 2020

This is a discussion for shiproom if there was not one.

I would more worried with the risk involved in updating the SDK and compiler. I would prefer to take it early when everyone is paying attention and problems are identified quickly, and not wait for the first servicing release. As I have said, it is a decision for the shiproom to make.

@jkotas
Copy link
Member

jkotas commented Sep 15, 2020

I have added two more changes (#42146 + #42191) that need to be included in this.

@ViktorHofer
Copy link
Member Author

@jkotas do you think that #42184 is required? Sounds to me that we introduce tons of warnings in our build without any noticeable customer impact.

@jkotas
Copy link
Member

jkotas commented Sep 15, 2020

Sounds to me that we introduce tons of warnings in our build without any noticeable customer impact.

The CI impact and .NET team engineer impact is very noticeable.

@ViktorHofer
Copy link
Member Author

Fixed by #42269

@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants