-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release/5.0 - Update SDK to final P8/RC1 #41684
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @ViktorHofer |
We believe this isn't necessary for shipping the product but we should do it anyway to minimize servicing diffs when taking a dependency on a serviced SDK. |
The release branch is building with Roslyn pinned to one of the preview versions. #42174 unpinned compiler in the master branch. Include this change in this port? |
Our plan was to work on this post RTM before the first servicing release. Is there risk involved with keeping the existing pinned compiler? If yes, I could prepare a PR today to make this ready for RC2. |
This is a discussion for shiproom if there was not one. I would more worried with the risk involved in updating the SDK and compiler. I would prefer to take it early when everyone is paying attention and problems are identified quickly, and not wait for the first servicing release. As I have said, it is a decision for the shiproom to make. |
The CI impact and .NET team engineer impact is very noticeable. |
Fixed by #42269 |
We are currently using a non-final P8 SDK in release/5.0. We should update to a final P8/RC1 SDK at some point.
To consume the RC1 SDK, the following changes are necessary:
We should do the same change in master but as it impacts more developers, it should be done as part of a batched rollout (ideally next week's one).
cc @dotnet/runtime-infrastructure
The text was updated successfully, but these errors were encountered: