Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TcpKeepalive_InfiniteTimeSpan_TranslatesToUInt32MaxValue fails in CI #45483

Closed
ViktorHofer opened this issue Dec 2, 2020 · 7 comments
Closed

TcpKeepalive_InfiniteTimeSpan_TranslatesToUInt32MaxValue fails in CI #45483

ViktorHofer opened this issue Dec 2, 2020 · 7 comments
Labels
area-System.Net.Http
Milestone
6.0.0

Comments

@ViktorHofer
Copy link
Member 

Assert.Equal() Failure\r\nExpected: 4294967295\r\nActual:   0
   at System.Net.Http.WinHttpHandlerUnitTests.WinHttpHandlerTest.TcpKeepalive_InfiniteTimeSpan_TranslatesToUInt32MaxValue() in /_/src/libraries/System.Net.Http.WinHttpHandler/tests/UnitTests/WinHttpHandlerTest.cs:line 160

https://dnceng.visualstudio.com/public/_build/results?buildId=905703&view=ms.vss-test-web.build-test-results-tab&runId=28903150&resultId=135589&paneView=debug

Configuration: net6.0-windows-Release-arm64-CoreCLR_release-Windows.10.Arm64.Open

cc @dotnet/ncl
@ghost
Copy link

ghost commented Dec 2, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details 
Assert.Equal() Failure\r\nExpected: 4294967295\r\nActual:   0
   at System.Net.Http.WinHttpHandlerUnitTests.WinHttpHandlerTest.TcpKeepalive_InfiniteTimeSpan_TranslatesToUInt32MaxValue() in /_/src/libraries/System.Net.Http.WinHttpHandler/tests/UnitTests/WinHttpHandlerTest.cs:line 160

https://dnceng.visualstudio.com/public/_build/results?buildId=905703&view=ms.vss-test-web.build-test-results-tab&runId=28903150&resultId=135589&paneView=debug

Configuration: net6.0-windows-Release-arm64-CoreCLR_release-Windows.10.Arm64.Open

cc @dotnet/ncl

Author: ViktorHofer
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 2, 2020
@ilyas1974
Copy link

https://github.com/dotnet/core-eng/issues/11511 was created for dnceng to address this issue.

@CarnaViire
Copy link
Member

I guess this issue is a duplicate of #45249

@ViktorHofer
Copy link
Member Author

jep, closing as dupe of #45249

@antonfirsov
Copy link
Member

Yeah, will be fixed by #45249.

@ViktorHofer note that the job Libraries Test Run release coreclr windows arm64 Release seems to be executed for refs/heads/master only and not for PR-s. This prevented us to notice the bug in advance. Any recommendations to handle this in general/in future?

@antonfirsov
Copy link
Member

& does this mean that no libraries tests are executed on ARM64 for individual PR-s?

@ViktorHofer
Copy link
Member Author

& does this mean that no libraries tests are executed on ARM64 for individual PR-s?

Right, as we don't have enough hardware to run them on every PR.

This prevented us to notice the bug in advance. Any recommendations to handle this in general/in future?

We do have a vendor who is supposed to file test failures from rolling builds. cc @danmosemsft

@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2021
@karelz karelz added this to the 6.0.0 milestone Jan 26, 2021
@karelz karelz removed the untriaged New issue has not been triaged by the area owner label Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Net.Http
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
7 participants
@CarnaViire @karelz @antonfirsov @ViktorHofer @ilyas1974 @Dotnet-GitSync-Bot and others