Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a PlatformIndependent tfm for System.Private.Runtime.InteropServices.JavaScript #46378

Closed
Anipik opened this issue Dec 23, 2020 · 4 comments
Closed

Add a PlatformIndependent tfm for System.Private.Runtime.InteropServices.JavaScript #46378

Anipik opened this issue Dec 23, 2020 · 4 comments
Assignees
@pavelsavara
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Milestone
7.0.0

Comments

@Anipik
Copy link
Contributor

Anipik commented Dec 23, 2020 •
edited
Loading

Currently System.Private.Runtime.InteropServices.JavaScript targets netcoreapp6.0-browser but we reference it from projects like system.console which targets other platforms as well.
We don't have platform specific project references except the projects referencing System.Private.Runtime.InteropServices.JavaScript
we should add a ref and platform Not Supported implementation for this project so all the configs could reference this project.

cc @safern @akoeplinger @ViktorHofer @ericstj
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-System.Runtime.InteropServices.JavaScript untriaged New issue has not been triaged by the area owner labels Dec 23, 2020
@lewing lewing added this to the 7.0.0 milestone Jun 30, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jun 30, 2021
@ViktorHofer ViktorHofer mentioned this issue Jan 30, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 30, 2022
@marek-safar
Copy link
Contributor

If we are going to do that we should remove .Private in the name

/cc @lewing @pavelsavara

@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 31, 2022
@pavelsavara
Copy link
Member

I'm working on this already. Stay tuned.

@pavelsavara pavelsavara self-assigned this Jan 31, 2022
@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label Jan 31, 2022
@ghost
Copy link

ghost commented Jan 31, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently System.Private.Runtime.InteropServices.JavaScript targets netcoreapp6.0-browser but we reference it from projects like system.console which targets other platforms as well.
We don't have platform specific project references except the projects referencing System.Private.Runtime.InteropServices.JavaScript
we should add a ref and platform Not Supported implementation for this project so all the configs could reference this project.

cc @safern @akoeplinger @ViktorHofer @ericstj

Author: Anipik
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 7.0.0

@pavelsavara pavelsavara mentioned this issue Jun 6, 2022
Merged
74 tasks
@pavelsavara
Copy link
Member

Fixed by #66304

@ghost ghost locked as resolved and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
5 participants
@lewing @marek-safar @pavelsavara @Anipik @Dotnet-GitSync-Bot