Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime.native.System.IO.Ports v5.0.0 release version nuget package depends on pre-release versions of other packages #47268

Closed
sokolovsa opened this issue Jan 21, 2021 · 9 comments

Comments

@sokolovsa
Copy link

Release version of runtime.native.System.IO.Ports (5.0.0) depends on following packages:
runtime.linux-arm.runtime.native.System.IO.Ports (>= 5.0.0-rtm.20519.4)
runtime.linux-arm64.runtime.native.System.IO.Ports (>= 5.0.0-rtm.20519.4)
runtime.linux-x64.runtime.native.System.IO.Ports (>= 5.0.0-rtm.20519.4)
runtime.osx-x64.runtime.native.System.IO.Ports (>= 5.0.0-rtm.20519.4)

Those are prerelease versions.
So nuget.exe fails to install System.IO.Ports with specific target framework unless -PreRelease is specified.
Example:
This fails:
NuGet.exe install System.IO.Ports -Version 5.0.0 -outputdirectory ioports -Framework net5.0 -Verbosity detailed

But this succeeds:
NuGet.exe install System.IO.Ports -Version 5.0.0 -outputdirectory ioports -Framework net5.0 -Verbosity detailed -PreRelease

Release versions of nuget packages should not have prerelease dependencies. Please fix.

@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.IO untriaged New issue has not been triaged by the area owner labels Jan 21, 2021
@hoyosjs
Copy link
Member

hoyosjs commented Jan 21, 2021

@ViktorHofer not sure if stabilization has to do with this.

@ghost
Copy link

ghost commented Jan 21, 2021

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Release version of runtime.native.System.IO.Ports (5.0.0) depends on following packages:
runtime.linux-arm.runtime.native.System.IO.Ports (>= 5.0.0-rtm.20519.4)
runtime.linux-arm64.runtime.native.System.IO.Ports (>= 5.0.0-rtm.20519.4)
runtime.linux-x64.runtime.native.System.IO.Ports (>= 5.0.0-rtm.20519.4)
runtime.osx-x64.runtime.native.System.IO.Ports (>= 5.0.0-rtm.20519.4)

Those are prerelease versions.
So nuget.exe fails to install System.IO.Ports with specific target framework unless -PreRelease is specified.
Example:
This fails:
NuGet.exe install System.IO.Ports -Version 5.0.0 -outputdirectory ioports -Framework net5.0 -Verbosity detailed

But this succeeds:
NuGet.exe install System.IO.Ports -Version 5.0.0 -outputdirectory ioports -Framework net5.0 -Verbosity detailed -PreRelease

Release versions of nuget packages should not have prerelease dependencies. Please fix.

Author: sokolovsa
Assignees: -
Labels:

area-Infrastructure-libraries, area-System.IO, untriaged

Milestone: -

@ViktorHofer
Copy link
Member

cc @Anipik

@safern
Copy link
Member

safern commented Feb 1, 2021

cc: @ericstj

@ericstj
Copy link
Member

ericstj commented Feb 1, 2021

@Anipik it looks like a bug in how we're building stable packages for System.IO.Ports. The process didn't result in stable versions for the runtime-specific packages.

https://www.nuget.org/packages/runtime.native.System.IO.Ports/5.0.0
image

We should service for this and also fix whatever in our release process is missing stabilization for these RID-specific packages.

@ericstj ericstj added bug and removed untriaged New issue has not been triaged by the area owner labels Feb 1, 2021
@ericstj ericstj added this to the 5.0.x milestone Feb 1, 2021
@Anipik
Copy link
Contributor

Anipik commented Feb 1, 2021

yes i will take a look and fix this

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Feb 2, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Feb 11, 2021
@ViktorHofer ViktorHofer added this to Servicing in Infrastructure Backlog Feb 17, 2021
@ViktorHofer
Copy link
Member

@Anipik should this issue be closed now?

@Anipik
Copy link
Contributor

Anipik commented Feb 19, 2021

the fix is in but the it will be shipped with 5.0.4

@ViktorHofer
Copy link
Member

If it's already merged then let's close the issue.

Infrastructure Backlog automation moved this from Servicing to Done (in 6.0.0) Feb 20, 2021
@dotnet dotnet locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants