RuntimeLicenseContext.GetSavedLicenseKey throws exception for dynamic assemblies

[BickelLukas]

Description

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/Design/DesigntimeLicenseContext.cs

Lines 80 to 83 in 1c9e200

	// Assemblies loaded in memory return empty string from Location.
	string location = asm.Location;
	if (location == string.Empty)
	continue;

In the System.ComponentModel.Design.RuntimeLicenseContext the following lines state that Location returns null for in memory loaded assemblies.

However System.Reflection.Emit.InternalAssemblyBuilder throws an exception when Location is accessed:

runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/AssemblyBuilder.cs

Line 105 in 1c9e200

public override string Location => throw new NotSupportedException(SR.NotSupported_DynamicAssembly);

Configuration

.NET 5.0
Windows x86

[ghost]

Tagging subscribers to this area: @safern
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/Design/DesigntimeLicenseContext.cs

Lines 80 to 83 in 1c9e200

	// Assemblies loaded in memory return empty string from Location.
	string location = asm.Location;
	if (location == string.Empty)
	continue;

In the System.ComponentModel.Design.RuntimeLicenseContext the following lines state that Location returns null for in memory loaded assemblies.

However System.Reflection.Emit.InternalAssemblyBuilder throws an exception when Location is accessed:

runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/AssemblyBuilder.cs

Line 105 in 1c9e200

public override string Location => throw new NotSupportedException(SR.NotSupported_DynamicAssembly);

Configuration

.NET 5.0
Windows x86

Author:	BickelLukas
Assignees:	-
Labels:	area-System.ComponentModel, untriaged
Milestone:	-

[safern]

@jkotas, @vitek-karas is this expected? It seems like this was changed on: b19d798 and on the PR review this is what was suggested to be done.

[jkotas]

We can either revert offending bit in the PR, or change the AssemblyBuilder string Location to just return empty string. I would vote for the latter.

[safern]

to just return empty string. I would vote for the latter.

Sounds good. It seems like this regressed 3.1 -> 5.0 on RuntimeLicenseContext.GetSavedLicenseKey I think we should port it back to 5.0?

[ghost]

Tagging subscribers to this area: @vitek-karas, @agocke, @CoffeeFlux, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

runtime/src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/Design/DesigntimeLicenseContext.cs

Lines 80 to 83 in 1c9e200

	// Assemblies loaded in memory return empty string from Location.
	string location = asm.Location;
	if (location == string.Empty)
	continue;

In the System.ComponentModel.Design.RuntimeLicenseContext the following lines state that Location returns null for in memory loaded assemblies.

However System.Reflection.Emit.InternalAssemblyBuilder throws an exception when Location is accessed:

runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/Emit/AssemblyBuilder.cs

Line 105 in 1c9e200

public override string Location => throw new NotSupportedException(SR.NotSupported_DynamicAssembly);

Configuration

.NET 5.0
Windows x86

Author:	BickelLukas
Assignees:	-
Labels:	area-AssemblyLoader-coreclr, area-System.Reflection.Emit, untriaged
Milestone:	-

[eerhardt]

Moving to System.Reflection.Emit to change the AssemblyBuilder.Location behavior to return string.Empty as proposed by @jkotas above.

[pedrobsaila]

Hi, I made a PR for this issue #57396

[vitek-karas]

Thanks to @pedrobsaila #57396 is merged and should fix the underlying issue in AssemblyBuilder. Could you please validate that the issue is fixed (in a couple of days one the fix makes it into the nightly build).

[ghost]

This issue has been marked needs-author-action and may be missing some important information.

[BickelLukas]

Seems to work now!