Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUIC: Aquiring msquic.dll on Windows and Linux #52085

Closed
2 tasks
JamesNK opened this issue Apr 30, 2021 · 10 comments
Closed
2 tasks

QUIC: Aquiring msquic.dll on Windows and Linux #52085

JamesNK opened this issue Apr 30, 2021 · 10 comments
Assignees
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
Milestone

Comments

@JamesNK
Copy link
Member

JamesNK commented Apr 30, 2021

There was an experimental Quic package that included msquic.dll for .NET 5. You could add that to your app to get the right msquic.dll version.

With .NET 6 today you must build msquic.dll and then copy it to the runtime location.

This is blocking integration testing and benchmarking in CI and perf environments.

  • Decide how msquic.dll will be acquired on Windows
  • Implementation
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 30, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

There was an experimental Quic package that included msquic.dll for .NET 5. You could add that to your app to get the right msquic.dll version.

With .NET 6 today you must build msquic.dll and then copy it to the runtime location.

The issue is for figuring out how msquic.dll will be acquired on Windows and implementing it.

This is blocking integration testing and benchmarking in CI or perf environments.

Author: JamesNK
Assignees: -
Labels:

area-System.Net.Quic

Milestone: -

@geoffkizer geoffkizer added this to the 6.0.0 milestone Apr 30, 2021
@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions and removed untriaged New issue has not been triaged by the area owner labels Apr 30, 2021
@karelz karelz added this to To Do (Low Priority) in HTTP/3 via automation Apr 30, 2021
@karelz karelz moved this from To Do (Low Priority) to To Do (High Priority) in HTTP/3 Apr 30, 2021
@karelz karelz changed the title QUIC: Aquiring msquic.dll on Windows QUIC: Aquiring msquic.dll on Windows and Linux May 18, 2021
@karelz karelz moved this from To Do (High Priority) to In Progress in HTTP/3 May 18, 2021
@karelz karelz assigned scalablecory and ManickaP and unassigned scalablecory Jun 22, 2021
@ManickaP
Copy link
Member

ManickaP commented Jul 8, 2021

@wfurt So we have officialy published linux packages, we're binplacing on Windows, can this be closed? Are we missing something still?

@JamesNK
Copy link
Member Author

JamesNK commented Jul 8, 2021

Is information about using the Linux package published somewhere?

@ManickaP
Copy link
Member

ManickaP commented Jul 8, 2021

Officially no, not yet, we should put that in docs though.
Do you personally want that now? I can forward you the mail.

@JamesNK
Copy link
Member Author

JamesNK commented Jul 8, 2021

Not urgently. Update instructions about msquic in the readme and I'll figure it out from that.

@ManickaP
Copy link
Member

ManickaP commented Jul 8, 2021

@ManickaP ManickaP closed this as completed Jul 8, 2021
HTTP/3 automation moved this from In Progress to Done Jul 8, 2021
@JamesNK JamesNK reopened this Jul 13, 2021
HTTP/3 automation moved this from Done to In Progress Jul 13, 2021
@JamesNK
Copy link
Member Author

JamesNK commented Jul 13, 2021

Re-opening as we don't see msquic.dll in the runtime directory (Windows SDK)

We've checked 6.0.0-preview.7.21360.10 and 6.0.0-preview.7.21362.3.

@JamesNK
Copy link
Member Author

JamesNK commented Jul 13, 2021

image

@ManickaP
Copy link
Member

ManickaP commented Aug 4, 2021

@JamesNK @wfurt : I think we can close this now, ASP.NET Core is getting the dll. Or is there still some problem?
Note that we have the rest of the packaging work covered in #55639

@wfurt
Copy link
Member

wfurt commented Aug 4, 2021

Let's close this as dup of #55639.
The new issue has more details and tracks remaining work.

@wfurt wfurt closed this as completed Aug 4, 2021
HTTP/3 automation moved this from In Progress to Done Aug 4, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Quic enhancement Product code improvement that does NOT require public API changes/additions
Projects
No open projects
HTTP/3
  
Done
Development

No branches or pull requests

6 participants