Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more collections in JSON source generator #53393

Closed
layomia opened this issue May 27, 2021 · 1 comment · Fixed by #55566
Closed

Support more collections in JSON source generator #53393

layomia opened this issue May 27, 2021 · 1 comment · Fixed by #55566
Assignees
@layomia
Labels
area-System.Text.Json
Milestone
6.0.0

Comments

@layomia
Copy link
Contributor

layomia commented May 27, 2021 •
edited
Loading

The JSON source generator currently supports only T[], List<T> (and derived types), and Dictionary<TKey, TValue> (and derived types) collections. It should support all collections supported by existing JsonSerializer functionality.

This is more relevant now since we do not have a trim-safe way to support most collections (#53205, #52268, #53256).

cc @eerhardt, @steveharter, @marek-safar, @jkotas
@layomia layomia added this to the 6.0.0 milestone May 27, 2021
@layomia layomia self-assigned this May 27, 2021
@ghost
Copy link

ghost commented May 27, 2021

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

The JSON source generator currently supports only T[], List<T> (and derived types), and Dictionary<TKey, TValue> (and derived types) collections. It should support all collections supported by existing JsonSerializer functionality.

This is more relevant now since we do not have a trim-safe way to support most collections (#53205, #52268, #53256)

cc @eerhardt, @steveharter, @marek-safar, @jkotas

Author: layomia
Assignees: layomia
Labels:

area-System.Text.Json
Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 27, 2021
@layomia layomia removed the untriaged New issue has not been triaged by the area owner label May 27, 2021
This was referenced May 27, 2021
Closed
Closed
@eerhardt eerhardt mentioned this issue May 28, 2021
Open
@layomia layomia mentioned this issue Jul 13, 2021
Merged
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Jul 13, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@layomia layomia

Labels
area-System.Text.Json
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Support more collections in STJ source generator layomia/dotnet_runtime
1 participant
@layomia