S.S.C.OpenSsl doesn't have UnsupportedOSPlatform annotation at assembly level on IosSimulator

[MaximLipnin]

Not sure whether it's an issue - when building S.S.C.OpenSsl for IosSimulator, the build produces a PNSE-assembly but the assembly metadata has [assembly: SupportedOSPlatform("iOS")] annotation even though it's marked as unsupported at csproj level using <UnsupportedOSPlatforms>windows;browser;android;ios;tvos</UnsupportedOSPlatforms> (see https://github.com/dotnet/runtime/blob/main/src/libraries/System.Security.Cryptography.OpenSsl/Directory.Build.props#L6)

[ghost]

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Not sure whether it's an issue - when building S.S.C.OpenSsl for IosSimulator, the build produces a PNSE-assembly but the assembly metadata has [assembly: SupportedOSPlatform("iOS")] annotation even though it's marked as unsupported at assembly level using <UnsupportedOSPlatforms>windows;browser;android;ios;tvos</UnsupportedOSPlatforms> (see https://github.com/dotnet/runtime/blob/main/src/libraries/System.Security.Cryptography.OpenSsl/Directory.Build.props#L6)

Author:	MaximLipnin
Assignees:	-
Labels:	area-System.Security, untriaged
Milestone:	-

[ghost]

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Not sure whether it's an issue - when building S.S.C.OpenSsl for IosSimulator, the build produces a PNSE-assembly but the assembly metadata has [assembly: SupportedOSPlatform("iOS")] annotation even though it's marked as unsupported at assembly level using <UnsupportedOSPlatforms>windows;browser;android;ios;tvos</UnsupportedOSPlatforms> (see https://github.com/dotnet/runtime/blob/main/src/libraries/System.Security.Cryptography.OpenSsl/Directory.Build.props#L6)

Author:	MaximLipnin
Assignees:	-
Labels:	area-Infrastructure-libraries
Milestone:	-

[akoeplinger]

@buyaa-n this sounds unexpected.

[buyaa-n]

That is expected, MSBuild would add SupportedOSPlatform attribute for any targeted build with the target platform, even it was not needed for PNSE only assembly

[ViktorHofer]

We could easily fix that in our infra if we want to but I'm not sure it's important...

[buyaa-n]

We could easily fix that in our infra if we want to but I'm not sure it's important...

I believe the cross-platform build is important because that is the one that will be shipped (which has the UnsupportedOSPlatform for windows, browser, android, ios, tvos as expected). Honestly, I do not know for what we need an assembly that throws inside for all APIs nor how/when it is used, so I could not say if fixing this is important or how important it is 😛

[safern]

Does it really matter though? Assemblies that throw not supported are runtime assemblies and the analyzer runs against the compile assemblies (ref). I know it's odd, but it doesn't seem to hurt anything.

[akoeplinger]

Yeah I didn't realize this was about the implementation assembly and not the ref assembly. I agree that it's not important for the former.