Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MONO][Interp] Tracking runtime test failures with Mono interpreter #54383

Open
13 of 26 tasks
fanyang-mono opened this issue Jun 17, 2021 · 6 comments
Open
13 of 26 tasks
Assignees
Labels
area-Codegen-Interpreter-mono tracking This issue is tracking the completion of other related issues.
Milestone

Comments

@fanyang-mono
Copy link
Member

fanyang-mono commented Jun 17, 2021

Here are the issues:

Probably worth investigating in NET6 - most of these are probably intentionally bad IL or other IL edge case behavior (and could be triaged to lower priority pretty quickly) - but they might uncover interpreter issues:

Also warrants a deeper investigation in .NET6 - the failures here are not well understood:

Other issues:

Lower priority:

@ghost
Copy link

ghost commented Jun 17, 2021

Tagging subscribers to this area: @BrzVlad
See info in area-owners.md if you want to be subscribed.

Issue Details

Comparing to Android x64 with JIT, here are the additional 93 tests failing to run on Android x64 with interpreter

Author: fanyang-mono
Assignees: fanyang-mono
Labels:

area-Codegen-Interpreter-mono, os-android

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jun 17, 2021
@BrzVlad
Copy link
Member

BrzVlad commented Jun 18, 2021

The title is misleading since these issues have nothing to do with android. These tests were already disabled on our CI runs on interpreter, however they were not triaged in detail. When it comes to android, it would have been more interesting to see whether there are any additional issues compared to desktop interpreter, which normally shouldn't be.

@fanyang-mono
Copy link
Member Author

The title is misleading since these issues have nothing to do with android. These tests were already disabled on our CI runs on interpreter, however they were not triaged in detail. When it comes to android, it would have been more interesting to see whether there are any additional issues compared to desktop interpreter, which normally shouldn't be.

I see. Let me clean the issues up.

@fanyang-mono fanyang-mono changed the title [MONO][Android][Interp] Tracking runtime test failures on Android x64 with interpreter [MONO][Interp] Tracking runtime test failures with Mono interpreter Jun 18, 2021
@fanyang-mono fanyang-mono added this to the 7.0.0 milestone Jun 21, 2021
@fanyang-mono
Copy link
Member Author

These are existing issues since .NET 5. None of them is currently block our customer. We will revisit them in .NET 7.

@SamMonoRT SamMonoRT removed the untriaged New issue has not been triaged by the area owner label Jun 21, 2021
@lambdageek
Copy link
Member

I went through and reorganized the list into 4 lists.

The first group "Probably worth investigating in NET6" are tests that I think a quick investigation will reprioritize for .NET 7. I suspect most of these are failing because the test is some bad IL, and the interpreter is generally not designed to gracefully exit for patently broken code.

The second group "Also warrants a deeper investigation in .NET6" Seem like they might be real high-impact issues.

The third group "Other issues" - particularly the JIT ones - I can't really tell from looking at them how big the impact is. I don't think they're intentionally bad IL, but I also can't tell from a superficial scanning of them if they're trying unlikely edge cases or something that is likely to be common

The fourth group are all the cases where the IL is intentionally bad and we're unlikely to see this from normal C# code.

@lambdageek lambdageek modified the milestones: 7.0.0, 6.0.0 Jun 22, 2021
@lambdageek lambdageek added the tracking This issue is tracking the completion of other related issues. label Jun 22, 2021
@fanyang-mono fanyang-mono modified the milestones: 6.0.0, 7.0.0 Jul 16, 2021
@fanyang-mono
Copy link
Member Author

Moving to 8.0.0

@fanyang-mono fanyang-mono modified the milestones: 7.0.0, 8.0.0 Aug 2, 2022
@SamMonoRT SamMonoRT modified the milestones: 8.0.0, Future May 18, 2023
@kotlarmilos kotlarmilos modified the milestones: Future, 9.0.0 Jul 13, 2023
@kotlarmilos kotlarmilos modified the milestones: 9.0.0, Future Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Codegen-Interpreter-mono tracking This issue is tracking the completion of other related issues.
Projects
None yet
Development

No branches or pull requests

5 participants