Move throw calls inside ThrowHelper.Get* methods

[eiriktsarpalis]

I believe that's indeed the point. We may need a pass at the reader/writer ThrowHelper implementation to throw inline rather than return exceptions, assuming there have been no JIT changes that render the optimization redundant.

Originally posted by @layomia in #55564 (comment)

[ghost]

Tagging subscribers to this area: @eiriktsarpalis, @layomia
See info in area-owners.md if you want to be subscribed.

Issue Details

---

I believe that's indeed the point. We may need a pass at the reader/writer ThrowHelper implementation to throw inline rather than return exceptions, assuming there have been no JIT changes that render the optimization redundant.

Originally posted by @layomia in #55564 (comment)

Author:	eiriktsarpalis
Assignees:	eiriktsarpalis
Labels:	area-System.Text.Json, untriaged
Milestone:	7.0.0

[GrabYourPitchforks]

For reference, the typical convention is to have Get* methods return an Exception instance, with Throw* methods throwing the Exception instance. See for example:

runtime/src/libraries/System.Private.CoreLib/src/System/ThrowHelper.cs

Lines 228 to 232 in fd5b60f

	[DoesNotReturn]
	internal static void ThrowArgumentException(ExceptionResource resource)
	{
	throw GetArgumentException(resource);
	}

[eiriktsarpalis]

What are the use cases for exposing Get* methods? All cases I'm aware of involve throwing the instance straight away.

[GrabYourPitchforks]

Maybe for wrapping exceptions? I agree it's atypical.

[eiriktsarpalis]

Maybe for wrapping exceptions? I agree it's atypical.

One use case seems to be calling throw helpers inside expressions, using a throw directly results in much simpler code overall. Though it didn't seem like particularly common occurrence, at least in System.Text.Json.