Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo) #60240

Open
VincentBu opened this issue Oct 11, 2021 · 12 comments
Open

Test failure System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo) #60240

VincentBu opened this issue Oct 11, 2021 · 12 comments
Assignees
@EgorBo
Labels
arch-x86 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI bug disabled-test The test is disabled in source code against the issue JitStress CLR JIT issues involving JIT internal stress modes needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration os-windows
Milestone
9.0.0

Comments

@VincentBu
Copy link

VincentBu commented Oct 11, 2021 •
edited by BruceForstall

Run: runtime-coreclr libraries-jitstressregs 20211010.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

category:correctness
theme:testing
skill-level:intermediate
cost:medium
impact:small
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Console untriaged New issue has not been triaged by the area owner labels Oct 11, 2021
@ghost
Copy link

ghost commented Oct 11, 2021

Tagging subscribers to this area: @dotnet/area-system-console
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime-coreclr libraries-jitstressregs 20211010.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42
Author: VincentBu
Assignees: -
Labels:

arch-x86, area-System.Console, os-windows, untriaged
Milestone: -

@carlossanlop
Copy link
Member

@dotnet/jit-contrib can anyone here help us investigate this issue?

The ConsoleKeyInfo has not been change for months.

This JIT test leg seems to be running once a week. This console test passes 47 times, and fails once, on Windows 10 amd64, with CoreCLR x86. https://dev.azure.com/dnceng/public/_test/analytics?definitionId=668&contextType=build

The test is comparing ConsoleKeyInfo instances. The .Equals() methods pass, but the == comparison fails.

Test log: https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-heads-main-5a8e57a8f2b14ffe9b/System.Console.Tests/1/console.dd29db9d.log?sv=2019-07-07&se=2021-10-30T09%3A32%3A44Z&sr=c&sp=rl&sig=CwCNOuPBFlwnNhP8FR4dwL0nJ7DVi5MHgRJFaJnOJTs%3D

Here's the code that fails:

runtime/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs

Lines 40 to 42 in 57bfe47

Assert.True(cki.Equals((object)other));
Assert.True(cki.Equals(other));
Assert.True(cki == other);

ConsoleKeyInfo is a readonly struct:

runtime/src/libraries/System.Console/src/System/ConsoleKeyInfo.cs

Line 8 in 57bfe47

public readonly struct ConsoleKeyInfo : IEquatable<ConsoleKeyInfo>

@carlossanlop carlossanlop added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed untriaged New issue has not been triaged by the area owner labels Oct 13, 2021
@ghost
Copy link

ghost commented Oct 13, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Run: runtime-coreclr libraries-jitstressregs 20211010.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42
Author: VincentBu
Assignees: -
Labels:

arch-x86, area-System.Console, os-windows, area-CodeGen-coreclr
Milestone: -

@carlossanlop carlossanlop added JitStress CLR JIT issues involving JIT internal stress modes untriaged New issue has not been triaged by the area owner and removed area-System.Console labels Oct 13, 2021
@JulieLeeMSFT JulieLeeMSFT added needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration and removed untriaged New issue has not been triaged by the area owner labels Oct 13, 2021
@JulieLeeMSFT JulieLeeMSFT modified the milestones: 6.0.0, 7.0.0 Oct 13, 2021
@JulieLeeMSFT
Copy link
Member

@EgorBo PTAL.
cc @dotnet/jit-contrib

@VincentBu
Copy link
Author

Failed again in: runtime-coreclr libraries-jitstressregs 20211024.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

@VincentBu
Copy link
Author

Failed again in: runtime-coreclr libraries-jitstressregs 20211107.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

@VincentBu
Copy link
Author

Failed again in: runtime-coreclr libraries-jitstressregs 20211121.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

@VincentBu
Copy link
Author

Failed again in: runtime-coreclr libraries-jitstressregs 20211205.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

@VincentBu
Copy link
Author

Failed again in: runtime-coreclr libraries-jitstressregs 20211219.1

Failed test:


net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

@VincentBu
Copy link
Author

Failed again in: runtime-coreclr libraries-jitstressregs 20220102.1

Failed test:

net7.0-windows-Release-x86-CoreCLR_checked-jitstressregs1-Windows.10.Amd64.Open

- System.Tests.ConsoleKeyInfoTests.Equals_SameData(cki: System.ConsoleKeyInfo)

Error message:

Assert.True() Failure
Expected: True
Actual:   False


Stack trace
   at System.Tests.ConsoleKeyInfoTests.Equals_SameData(ConsoleKeyInfo cki) in /_/src/libraries/System.Console/tests/ConsoleKeyInfoTests.cs:line 42

This was referenced Jan 4, 2022
Merged
Merged
@jkotas jkotas added disabled-test The test is disabled in source code against the issue bug labels Jan 5, 2022
@EgorBo
Copy link
Member

EgorBo commented Aug 12, 2022

I wasn't able to reproduce this, but I'll try again on Monday once I am home and backport to 7.0 if it turns out to be important/gc hole

@EgorBo EgorBo modified the milestones: 7.0.0, 8.0.0 Aug 12, 2022
@EgorBo
Copy link
Member

EgorBo commented Aug 9, 2023

Doesn't repro no matter what, I'll file a PR to re-enable this test

@EgorBo EgorBo modified the milestones: 8.0.0, 9.0.0 Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EgorBo EgorBo

Labels
arch-x86 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI bug disabled-test The test is disabled in source code against the issue JitStress CLR JIT issues involving JIT internal stress modes needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration os-windows
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
5 participants
@EgorBo @carlossanlop @jkotas @VincentBu @JulieLeeMSFT