Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm][debugger] Refactor evaluateOnCallFrame #69639

Closed
ilonatommy opened this issue May 21, 2022 · 4 comments
Closed

wasm][debugger] Refactor evaluateOnCallFrame #69639

ilonatommy opened this issue May 21, 2022 · 4 comments
Assignees
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Milestone

Comments

@ilonatommy
Copy link
Member

Currently: we have 2 functions handling on-frame-evaluation:

  • Resolve, targeting simple expressions that can be resolved talking to the runtime (e.g. local variables, object members, static classes etc)
  • CompileAndRunTheExpression, targeting more complex expressions using Roslyn. It is triggered only when Resolve fails in evaluating the expression.

Goal:
merge these two processes because some expressions require both sources of information, it could help solving these issues: #66823, #67029, #66824.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Debugger-mono labels May 21, 2022
@ilonatommy ilonatommy self-assigned this May 21, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label May 21, 2022
@ghost
Copy link

ghost commented May 21, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Currently: we have 2 functions handling on-frame-evaluation:

  • Resolve, targeting simple expressions that can be resolved talking to the runtime (e.g. local variables, object members, static classes etc)
  • CompileAndRunTheExpression, targeting more complex expressions using Roslyn. It is triggered only when Resolve fails in evaluating the expression.

Goal:
merge these two processes because some expressions require both sources of information, it could help solving these issues: #66823, #67029, #66824.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@lewing lewing removed the untriaged New issue has not been triaged by the area owner label May 25, 2022
@lewing lewing added this to the 7.0.0 milestone May 25, 2022
@ilonatommy ilonatommy modified the milestones: 7.0.0, 8.0.0 Jul 27, 2022
@lewing
Copy link
Member

lewing commented Jul 10, 2023

@ilonatommy what is the status of this?

@ilonatommy
Copy link
Member Author

Not started. It's not of a high priority, so let me move it to the future.

@ilonatommy ilonatommy modified the milestones: 8.0.0, Future Jul 11, 2023
@ilonatommy
Copy link
Member Author

Connected issues got solved without refactoring. Closing as not needed right now.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

No branches or pull requests

2 participants