Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix per object heap commit tracking for regions #71790

Closed
cshung opened this issue Jul 7, 2022 · 1 comment · Fixed by #72229
Closed

Fix per object heap commit tracking for regions #71790

cshung opened this issue Jul 7, 2022 · 1 comment · Fixed by #72229
Assignees
@cshung
Labels
area-GC-coreclr
Milestone
7.0.0

Comments

@cshung
Copy link
Member

cshung commented Jul 7, 2022

We need to make sure the per object heap commit tracking feature works correctly under regions.

Right now, when a region are obtained from or returned to the regions free list, the committed_by_oh array is not updated. As a result, the memory is repurposed but the arrays are not updated, we need to fix that.
@cshung cshung added this to the 7.0.0 milestone Jul 7, 2022
@cshung cshung self-assigned this Jul 7, 2022
@ghost
Copy link

ghost commented Jul 7, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

We need to make sure the per object heap commit tracking feature works correctly under regions.

Right now, when a region are obtained from or returned to the regions free list, the committed_by_oh array is not updated. As a result, the memory is repurposed but the arrays are not updated, we need to fix that.

Author: cshung
Assignees: cshung
Labels:

area-GC-coreclr
Milestone: 7.0.0

@cshung cshung mentioned this issue Jul 14, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 14, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cshung cshung

Labels
area-GC-coreclr
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fixing the per object hard limit support for regions cshung/runtime
1 participant
@cshung