Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normal-microsoft.extensions.configuration.binder.tests work item #72465

Closed
runfoapp bot opened this issue Jul 19, 2022 · 8 comments · Fixed by #72485
Closed

normal-microsoft.extensions.configuration.binder.tests work item #72465

runfoapp bot opened this issue Jul 19, 2022 · 8 comments · Fixed by #72485
Labels
arch-wasm WebAssembly architecture area-Extensions-Configuration blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Milestone
7.0.0

Comments

@runfoapp
Copy link

runfoapp bot commented Jul 19, 2022 •
edited
Loading

Build Kind Start Time
1889446 PR 72272 2022-19-07
1889812 Rolling 2022-19-07
1889994 PR 72445 2022-19-07
1889995 PR 71385 2022-19-07
1890405 PR 72445 2022-19-07
1890767 PR 72467 2022-19-07
1890969 PR 71385 2022-19-07
1891294 PR 72394 2022-19-07
1891667 PR 72497 2022-19-07
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 19, 2022
@tlakollo
Copy link
Contributor

Several tests are failing sporadically in the runtime-extra-platforms rolling build after #68133 was merged

Following is an example of one of the failure signatures:

[13:30:24] info: Starting:    Microsoft.Extensions.Configuration.Binder.Tests.dll
[13:30:25] fail: [FAIL] Microsoft.Extensions.Configuration.Binder.Test.ConfigurationBinderTests.CanBindNonInstantiatedSortedSetWithSomeValues
[13:30:25] info: System.InvalidOperationException : Cannot create instance of type 'System.Collections.Generic.SortedSet`1[System.String]' because it has multiple public parameterized constructors.
[13:30:25] info:    at Microsoft.Extensions.Configuration.ConfigurationBinder.CreateInstance(Type , IConfiguration , BinderOptions )
[13:30:25] info:    at Microsoft.Extensions.Configuration.ConfigurationBinder.BindInstance(Type , BindingPoint , IConfiguration , BinderOptions )
[13:30:25] info:    at Microsoft.Extensions.Configuration.ConfigurationBinder.BindProperty(PropertyInfo , Object , IConfiguration , BinderOptions )
[13:30:25] info:    at Microsoft.Extensions.Configuration.ConfigurationBinder.BindProperties(Object , IConfiguration , BinderOptions )
[13:30:25] info:    at Microsoft.Extensions.Configuration.ConfigurationBinder.BindInstance(Type , BindingPoint , IConfiguration , BinderOptions )
[13:30:25] info:    at Microsoft.Extensions.Configuration.ConfigurationBinder.Get(IConfiguration , Type , Action`1 )
[13:30:25] info:    at Microsoft.Extensions.Configuration.ConfigurationBinder.Get[ComplexOptions](IConfiguration , Action`1 )
[13:30:25] info:    at Microsoft.Extensions.Configuration.ConfigurationBinder.Get[ComplexOptions](IConfiguration )
[13:30:25] info:    at Microsoft.Extensions.Configuration.Binder.Test.ConfigurationBinderTests.CanBindNonInstantiatedSortedSetWithSomeValues()
[13:30:25] info:    at System.Reflection.MethodInvoker.InterpretedInvoke(Object , Span`1 , BindingFlags )
[13:30:25] info: Finished:    Microsoft.Extensions.Configuration.Binder.Tests.dll
[13:30:25] info: 
[13:30:25] info: === TEST EXECUTION SUMMARY ===
[13:30:25] info: Total: 213, Errors: 0, Failed: 1, Skipped: 0, Time: 1.1558219s

@ghost
Copy link

ghost commented Jul 19, 2022

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Tracking Issue: normal-microsoft.extensions.configuration.binder.tests work item

Build Definition Kind Run Name Console Core Dump Test Results Run Client
1889995 runtime-extra-platforms PR 71385 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889995 runtime-extra-platforms PR 71385 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889994 runtime-extra-platforms PR 72445 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889994 runtime-extra-platforms PR 72445 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889812 runtime-extra-platforms Rolling net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889812 runtime-extra-platforms Rolling net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889446 runtime-extra-platforms PR 72272 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889446 runtime-extra-platforms PR 72272 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
4 4 4
Author: runfoapp[bot]
Assignees: -
Labels:

untriaged, area-Extensions-Configuration
Milestone: -

@eerhardt
Copy link
Member

@tarekgh @SteveDunn - can you take a look?

@tarekgh
Copy link
Member

tarekgh commented Jul 19, 2022

Yes, will take a look

@tarekgh
Copy link
Member

tarekgh commented Jul 19, 2022

A quick look shows that this failure is happening only in WASM scenario. The failure is about not finding the default constructor (which not taking any arguments) of SortedSet<string> type. This means somehow this constructor code got trimmed. Looking at what would be the best fix here.

@radical radical mentioned this issue Jul 19, 2022
Closed
@radical radical added the arch-wasm WebAssembly architecture label Jul 19, 2022
@ghost
Copy link

ghost commented Jul 19, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Tracking Issue: normal-microsoft.extensions.configuration.binder.tests work item

Build Definition Kind Run Name Console Core Dump Test Results Run Client
1889995 runtime-extra-platforms PR 71385 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889995 runtime-extra-platforms PR 71385 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889994 runtime-extra-platforms PR 72445 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889994 runtime-extra-platforms PR 72445 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889812 runtime-extra-platforms Rolling net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889812 runtime-extra-platforms Rolling net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889446 runtime-extra-platforms PR 72272 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py
1889446 runtime-extra-platforms PR 72272 net7.0-Browser-Release-wasm-Mono_Release-normal-Ubuntu.1804.Amd64.Open console.log test results runclient.py

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
4 4 4
Author: runfoapp[bot]
Assignees: -
Labels:

arch-wasm, untriaged, area-Extensions-Configuration
Milestone: -

@radical radical added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' and removed untriaged New issue has not been triaged by the area owner labels Jul 19, 2022
@runfoapp runfoapp bot mentioned this issue Jul 19, 2022
Closed
@tarekgh tarekgh mentioned this issue Jul 19, 2022
Merged
@tarekgh tarekgh added this to the 7.0.0 milestone Jul 19, 2022
@tarekgh
Copy link
Member

tarekgh commented Jul 20, 2022

Thanks @radical for helping validating the fix.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Extensions-Configuration blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms'
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fix Configuration Binder Test with WASM and Trimming tarekgh/runtime
4 participants
@radical @eerhardt @tarekgh @tlakollo