Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent Android test refactor broke HttpStress builds #72598

Closed
antonfirsov opened this issue Jul 21, 2022 · 1 comment · Fixed by #72601
Closed

Recent Android test refactor broke HttpStress builds #72598

antonfirsov opened this issue Jul 21, 2022 · 1 comment · Fixed by #72601
Assignees
@antonfirsov
Labels
area-System.Net.Http
Milestone
7.0.0

Comments

@antonfirsov
Copy link
Member

#71385 introduced a build failure in the class StressClient. The method CreateHttpClient does not exist that context:
https://github.com/dotnet/runtime/pull/71385/files#diff-a4f53800a0e6b2a16cda442c903251d398bef9226539ed6312f71bdbf3998ce4

@simonrozsival @akoeplinger when touching stress test code, please make sure to run the affected stress tests under the PR:

/azp run runtime-libraries stress-http
/azp run runtime-libraries stress-ssl

(I'm about to push a quick fix since I need it running ASAP)
@antonfirsov antonfirsov added this to the 7.0.0 milestone Jul 21, 2022
@antonfirsov antonfirsov self-assigned this Jul 21, 2022
@ghost
Copy link

ghost commented Jul 21, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

#71385 introduced a build failure in the class StressClient. The method CreateHttpClient does not exist that context:
https://github.com/dotnet/runtime/pull/71385/files#diff-a4f53800a0e6b2a16cda442c903251d398bef9226539ed6312f71bdbf3998ce4

@simonrozsival @akoeplinger when touching stress test code, please make sure to run the affected stress tests under the PR:

/azp run runtime-libraries stress-http
/azp run runtime-libraries stress-ssl

(I'm about to push a quick fix since I need it running ASAP)

Author: antonfirsov
Assignees: antonfirsov
Labels:

area-System.Net.Http
Milestone: 7.0.0

@antonfirsov antonfirsov mentioned this issue Jul 21, 2022
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 21, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@antonfirsov antonfirsov

Labels
area-System.Net.Http
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Fix HttpStress build antonfirsov/runtime
1 participant
@antonfirsov