[LSG] warning CS8785: Generator 'LoggerMessageGenerator' failed to generate source.

[pengweiqhca]

Description

LoggerMessageGenerator not support [Obsolete] with argment(s).

Reproduction Steps

public static partial class LoggerExtensions
{
	[LoggerMessage((int)LogLevel.Trace, LogLevel.Trace, "{Msg}")]
	[Obsolete("test")]
	public static partial void Trace(this ILogger logger, string msg, Exception? ex = null);
}

Expected behavior

Not error.

Actual behavior

warning CS8785: Generator 'LoggerMessageGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'InvalidCastException' with message 'Specified cast is not valid.'

Regression?

No response

Known Workarounds

Delete [Obsolete] argment.

Configuration

No response

Other information

No response

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-logging
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

LoggerMessageGenerator not support [Obsolete] with parameter.

Reproduction Steps

public static partial class LoggerExtensions
{
	[LoggerMessage((int)LogLevel.Trace, LogLevel.Trace, "{Msg}")]
	[Obsolete("test")]
	public static partial void Trace(this ILogger logger, string msg, Exception? ex = null);
}

Expected behavior

Not error.

Actual behavior

warning CS8785: Generator 'LoggerMessageGenerator' failed to generate source. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'InvalidCastException' with message 'Specified cast is not valid.'

Regression?

No response

Known Workarounds

Delete [Obsolete] parameter.

Configuration

No response

Other information

No response

Author:	pengweiqhca
Assignees:	-
Labels:	untriaged, area-Extensions-Logging
Milestone:	-

[danmoseley]

Thanks for the report. Would you be interested to offer a PR?

[allantargino]

I wasn't able to reproduce this error using Microsoft.Extensions.Logging version 7.0.0.

I don't get any compilation errors, and I can confirm the annotations are being added by the compiler to the assembly:

Do you have more information about your environment/runtime?

[pengweiqhca]

@allantargino Sorray, I test again, dotnet sdk 7.0.100, Microsoft.Extensions.Logging 7.0.0 no error, 6.0.0 is error.

[tarekgh]

@allantargino @pengweiqhca how this is important to port to 6.0? We have a servicing bar which needs some justification to port it. I am seeing there is an easy workaround to reference 7.0 version of the logging libraries. right?

[ghost]

This issue has been marked needs-author-action and may be missing some important information.

[pengweiqhca]

I have solved in other way. But I think it's a compatibility issue, and .NET 6 still servicing.

[allantargino]

@tarekgh I'd say this isn't a critical fix. Like you said, the workaround is just to reference the new version. Given it doesn't have any breaking changes, I believe it is fair to not port it back.

[tarekgh]

Per the replies I am going to close this issue and the PR and we can consider the porting to 6.0 if we see more demands on it in the future.