Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many jump stubs #77638

Closed
EgorBo opened this issue Oct 29, 2022 · 2 comments
Closed

Too many jump stubs #77638

EgorBo opened this issue Oct 29, 2022 · 2 comments
Labels
area-VM-coreclr

Comments

@EgorBo
Copy link
Member

EgorBo commented Oct 29, 2022 •
edited
Loading

I noticed that BingSNR (when I run it locally on Windows-x64) emits 44k jump stubs (44k calls to allocJumpStubBlock) - it happens because the app itself is quite big and its working set is 7-10Gb (thus, we likely have multiple loaderheaps) running locally for a benchmark. Also I noticed that the process of emitting jump stubs is quite hot, e.g. here is a flamegraph for a randomly selected time frame after start: 50s - 60s:

image

Can we do anything with this? E.g. just like in #64148 to emit 64bit addresses to precode slots directly in methods
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Oct 29, 2022
@EgorBo EgorBo mentioned this issue Oct 29, 2022
Closed
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Oct 29, 2022
@EgorBo
Copy link
Member Author

EgorBo commented Oct 29, 2022

Merging with #62302

@EgorBo EgorBo closed this as completed Oct 29, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Oct 29, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 29, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-VM-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit less jump-stubs on x64 EgorBo/runtime-1
1 participant
@EgorBo