DataTable, the result of the new operator is checked for null

[VasilievSerg]

The code:

protected virtual XmlSchema? GetSchema()
{
    if (GetType() == typeof(DataTable))
    {
        return null;
    }
    MemoryStream stream = new MemoryStream();

    XmlWriter writer = new XmlTextWriter(stream, null); // <=
    if (writer != null)    // <=
    {
        (new XmlTreeGen(SchemaFormat.WebService)).Save(this, writer);
    }
    stream.Position = 0;
    return XmlSchema.Read(new XmlTextReader(stream), null);
}

The writer variable is checked for null after the object was created via the new operator. As a result, the writer != null expression is always true.

Is it an error or just redundant code?

[ghost]

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The code:

protected virtual XmlSchema? GetSchema()
{
    if (GetType() == typeof(DataTable))
    {
        return null;
    }
    MemoryStream stream = new MemoryStream();

    XmlWriter writer = new XmlTextWriter(stream, null); // <=
    if (writer != null)    // <=
    {
        (new XmlTreeGen(SchemaFormat.WebService)).Save(this, writer);
    }
    stream.Position = 0;
    return XmlSchema.Read(new XmlTextReader(stream), null);
}

The writer variable is checked for null after the object was created via the new operator. As a result, the writer != null expression is always true.

Is it an error or just redundant code?

Author:	VasilievSerg
Assignees:	-
Labels:	area-System.Xml
Milestone:	-