Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/arm64: 1 Regression on 3/7/2023 1:52:33 AM #83217

Closed
performanceautofiler bot opened this issue Mar 9, 2023 · 5 comments
Closed

[Perf] Windows/arm64: 1 Regression on 3/7/2023 1:52:33 AM #83217

performanceautofiler bot opened this issue Mar 9, 2023 · 5 comments
Assignees
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark

Comments

@performanceautofiler
Copy link

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline c16c7aedd1dbccbb085b6451ad096fda0c1d194f
Compare 2d5a9162f6bd9583981d54363d077a04e4efc868
Diff Diff

Regressions in System.Tests.Perf_Double

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ToStringWithFormat - Duration of single invocation 194.68 ns 208.01 ns 1.07 0.00 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_Double*'

Payloads

Baseline
Compare

Histogram

System.Tests.Perf_Double.ToStringWithFormat(value: -1.7976931348623157E+308, format: "G17")


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 208.00995983609883 > 204.34733903495226.
IsChangePoint: Marked as a change because one of 1/13/2023 8:11:05 PM, 2/17/2023 12:28:21 PM, 3/6/2023 9:06:14 PM, 3/9/2023 2:25:45 AM falls between 2/28/2023 7:22:28 AM and 3/9/2023 2:25:45 AM.
IsRegressionStdDev: Marked as regression because -29.140714100285486 (T) = (0 -208.60392097831192) / Math.Sqrt((0.2243479113399539 / (35)) + (1.5413133171567506 / (7))) is less than -2.0210753903043583 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (7) - 2, .025) and -0.07123441306481802 = (194.7322812207768 - 208.60392097831192) / 194.7322812207768 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@performanceautofiler performanceautofiler bot added the untriaged New issue has not been triaged by the area owner label Mar 9, 2023
@EgorBo EgorBo removed the untriaged New issue has not been triaged by the area owner label Mar 9, 2023
@EgorBo EgorBo transferred this issue from dotnet/perf-autofiling-issues Mar 9, 2023
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Mar 9, 2023
@EgorBo EgorBo added arch-arm64 tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Mar 9, 2023
@EgorBo EgorBo assigned jakobbotsch and unassigned tannergooding Mar 9, 2023
@ghost
Copy link

ghost commented Mar 9, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline c16c7aedd1dbccbb085b6451ad096fda0c1d194f
Compare 2d5a9162f6bd9583981d54363d077a04e4efc868
Diff Diff

Regressions in System.Tests.Perf_Double

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
ToStringWithFormat - Duration of single invocation 194.68 ns 208.01 ns 1.07 0.00 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_Double*'

Payloads

Baseline
Compare

Histogram

System.Tests.Perf_Double.ToStringWithFormat(value: -1.7976931348623157E+308, format: "G17")


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 208.00995983609883 > 204.34733903495226.
IsChangePoint: Marked as a change because one of 1/13/2023 8:11:05 PM, 2/17/2023 12:28:21 PM, 3/6/2023 9:06:14 PM, 3/9/2023 2:25:45 AM falls between 2/28/2023 7:22:28 AM and 3/9/2023 2:25:45 AM.
IsRegressionStdDev: Marked as regression because -29.140714100285486 (T) = (0 -208.60392097831192) / Math.Sqrt((0.2243479113399539 / (35)) + (1.5413133171567506 / (7))) is less than -2.0210753903043583 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (35) + (7) - 2, .025) and -0.07123441306481802 = (194.7322812207768 - 208.60392097831192) / 194.7322812207768 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: tannergooding
Labels:

arch-arm64, tenet-performance, tenet-performance-benchmarks, area-CodeGen-coreclr, untriaged

Milestone: -

@EgorBo
Copy link
Member

EgorBo commented Mar 9, 2023

Seems to be regressed via #82766 cc @jakobbotsch (arm64)

@jakobbotsch
Copy link
Member

#82766 had only these 4 diffs in benchmarks:
image

Will wait a bit to see if this one doesn't return back to normal before I go investigate

@jakobbotsch
Copy link
Member

This is back to normal:
image

@jakobbotsch jakobbotsch closed this as not planned Won't fix, can't repro, duplicate, stale Mar 16, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Mar 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-arm64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Development

No branches or pull requests

3 participants