Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Build Analysis" report is missing a build break in a test #84049

Closed
markples opened this issue Mar 28, 2023 · 7 comments
Closed

"Build Analysis" report is missing a build break in a test #84049

markples opened this issue Mar 28, 2023 · 7 comments

Comments

@markples
Copy link
Member

or perhaps the build break is being classified along with different known failures? Note that the build break is due to an analyzer.

I don't know if these links will persist so here are links + screenshots. This is the analysis: https://github.com/dotnet/runtime/pull/83895/checks?check_run_id=12264638203

image

And this is a failure:
https://github.com/dotnet/runtime/pull/83895/checks?check_run_id=12262235297

image

@markples markples added this to the 8.0.0 milestone Mar 28, 2023
@ghost
Copy link

ghost commented Mar 28, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

or perhaps the build break is being classified along with different known failures? Note that the build break is due to an analyzer.

I don't know if these links will persist so here are links + screenshots. This is the analysis: https://github.com/dotnet/runtime/pull/83895/checks?check_run_id=12264638203

image

And this is a failure:
https://github.com/dotnet/runtime/pull/83895/checks?check_run_id=12262235297

image

Author: markples
Assignees: -
Labels:

area-Infrastructure

Milestone: 8.0.0

@hoyosjs
Copy link
Member

hoyosjs commented Mar 29, 2023

@missymessa @AlitzelMendez is there any chance you can check this? The second error doesn't really match the blob on #83655, but it's getting matched.

@hoyosjs
Copy link
Member

hoyosjs commented Mar 29, 2023

@markples I fixed the issues. Now they actually surface.

@hoyosjs
Copy link
Member

hoyosjs commented Mar 29, 2023

It doesn't explain the second issue matching, hence asking help from Ali

@AlitzelMendez
Copy link
Member

At the moment that this build was analyzed, it matched the errors correctly.

The problem was on the regex for the issue: #83655

When this was analyzed the regex was:
"ErrorPattern": "['WasmTestOnBrowser.+ END OF WORK ITEM LOG: Command timed out, and was killed]" which was basically matching everything.

This was fixed two days ago:
image
but at that point this error probably matched a ton of builds, in fact if you see at the numbers from the last 7 days the number is unusually high (546 builds).

When the error is updated, we analyzed the builds from the last 24 hours, but this build wasn't part of that timeframe so we didn't reanalyze the build.

@hoyosjs
Copy link
Member

hoyosjs commented Mar 29, 2023

Wow, thanks Ali :) it's hard to know where in time things happen sometimes. Appreciate the investigation.

@hoyosjs hoyosjs closed this as completed Mar 29, 2023
@markples
Copy link
Member Author

Thanks to both of you!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants