Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Invalid result with negated op in compare on arm64 #85225

Closed
jakobbotsch opened this issue Apr 23, 2023 · 3 comments · Fixed by #85230
Closed

JIT: Invalid result with negated op in compare on arm64 #85225

jakobbotsch opened this issue Apr 23, 2023 · 3 comments · Fixed by #85230
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Comments

@jakobbotsch
Copy link
Member

// Generated by Fuzzlyn v1.5 on 2023-04-23 16:11:05
// Run on Arm64 Linux
// Seed: 17525435962662079854
// Reduced from 204.8 KiB to 0.2 KiB in 00:02:20
// Debug: Prints 0 line(s)
// Release: Prints 1 line(s)
public class Program
{
    public static uint s_2;
    public static void Main()
    {
        int vr0 = default(int);
        if (56058 < (uint)(-s_2))
        {
            System.Console.WriteLine(vr0);
        }
    }
}

cc @TIHan, related to #84667?

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 23, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 23, 2023
@ghost
Copy link

ghost commented Apr 23, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details
// Generated by Fuzzlyn v1.5 on 2023-04-23 16:11:05
// Run on Arm64 Linux
// Seed: 17525435962662079854
// Reduced from 204.8 KiB to 0.2 KiB in 00:02:20
// Debug: Prints 0 line(s)
// Release: Prints 1 line(s)
public class Program
{
    public static uint s_2;
    public static void Main()
    {
        int vr0 = default(int);
        if (56058 < (uint)(-s_2))
        {
            System.Console.WriteLine(vr0);
        }
    }
}

cc @TIHan, related to #84667?

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged

Milestone: -

@jakobbotsch
Copy link
Member Author

There are also quite a few assertion failures:

// Generated by Fuzzlyn v1.5 on 2023-04-23 16:08:36
// Run on Arm64 Linux
// Seed: 14539137576033306350
// Reduced from 132.6 KiB to 0.2 KiB in 00:00:48
// Hits JIT assert in Release:
// Assertion failed 'op2->gtGetOp1()->isContained()' in 'Program:Main(Fuzzlyn.ExecutionServer.IRuntime)' during 'Generate code' (IL size 36; hash 0xade6b36b; FullOpts)
// 
//     File: /__w/1/s/src/coreclr/jit/codegenarm64.cpp Line: 4581
// 
public class C0
{
    public bool F8;
}

public class Program
{
    public static C0 s_11;
    public static byte s_35;
    public static sbyte s_44;
    public static void Main()
    {
        s_11.F8 |= s_35 < (-(1 << s_44));
    }
}
// Generated by Fuzzlyn v1.5 on 2023-04-23 15:24:06
// Run on Arm64 MacOS
// Seed: 17107947400844937226
// Reduced from 42.1 KiB to 0.5 KiB in 00:00:16
// Hits JIT assert in Release:
// Assertion failed 'ins == INS_cmp' in 'Program:M17(long)' during 'Generate code' (IL size 32; hash 0x81994f2b; FullOpts)
// 
//     File: /Users/runner/work/1/s/src/coreclr/jit/codegenarm64.cpp Line: 4568
// 
public class Program
{
    public static IRuntime s_rt;
    public static uint s_4;
    public static void Main()
    {
        M17(0);
    }

    public static void M17(long arg0)
    {
        short var0 = default(short);
        if ((ulong)((-s_4) & arg0) >= 1)
        {
            s_rt.WriteLine(var0);
        }
    }
}

@TIHan TIHan self-assigned this Apr 23, 2023
@TIHan
Copy link
Member

TIHan commented Apr 23, 2023

Yea, it looks related.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 24, 2023
@ghost ghost removed in-pr There is an active PR which will close this issue when it is merged untriaged New issue has not been triaged by the area owner labels Apr 26, 2023
@dotnet dotnet locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants