[API Proposal]: ArgumentException.ThrowIfNullOrEmpty for collection

[WeihanLi]

Background and motivation

Sometimes, we may also need to check if a collection is empty just likes the string.IsNullOrEmpty

for example:

runtime/src/mono/wasm/host/RunConfiguration.cs

Lines 46 to 47 in 7173823

	if (HostProperties.HostConfigs is null || HostProperties.HostConfigs.Count == 0)
	throw new Exception($"no perHostConfigs found");

https://github.com/Azure/azure-sdk-for-net/blob/aea202adfea6f1dbb117ab9f8f3cde7028d8d2d1/sdk/core/Azure.Core/src/Shared/Argument.cs#L82-L84

API Proposal

namespace System;

public class ArgumentException : SystemException
{
    public static void ThrowIfNullOrEmpty<T>([NotNull]ICollection<T>? argument, [CallerArgumentExpression(nameof(argument))] string? paramName = null)
    {
        ArgumentNullException.ThrowIfNull(argument, paramName);
        if (argument.Count == 0)
        {
            throw new ArgumentException("The collection is empty...", paramName);  
        }
    }
}

API Usage

var arr = Array.Empty<int>();
ArgumentException.ThrowIfNullOrEmpty();

// throwing the ArgumentException out

Alternative Designs

No response

Risks

No response

[jkotas]

This was discussed and rejected in #62628 (comment) : We don't believe we need an overload of ThrowIfNullOrEmpty for collections as this feels rare.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Background and motivation

Sometimes, we may also need to check if a collection is empty just likes the string.IsNullOrEmpty

for example:

runtime/src/mono/wasm/host/RunConfiguration.cs

Lines 46 to 47 in 7173823

	if (HostProperties.HostConfigs is null || HostProperties.HostConfigs.Count == 0)
	throw new Exception($"no perHostConfigs found");

https://github.com/Azure/azure-sdk-for-net/blob/aea202adfea6f1dbb117ab9f8f3cde7028d8d2d1/sdk/core/Azure.Core/src/Shared/Argument.cs#L82-L84

API Proposal

namespace System;

public class ArgumentException : SystemException
{
    public static void ThrowIfNullOrEmpty<T>([NotNull]ICollection<T>? argument, [CallerArgumentExpression(nameof(argument))] string? paramName = null)
    {
        ArgumentNullException.ThrowIfNull(argument, paramName);
        if (argument.Count == 0)
        {
            throw new ArgumentException("The collection is empty...", paramName);  
        }
    }
}

API Usage

var arr = Array.Empty<int>();
ArgumentException.ThrowIfNullOrEmpty();

// throwing the ArgumentException out

Alternative Designs

No response

Risks

No response

Author:	WeihanLi
Assignees:	-
Labels:	api-suggestion, area-System.Runtime, untriaged
Milestone:	-

[stephentoub]

Also here:
#77749 (comment)
If we felt it was valuable, we could do it just for arrays, but using the interfaces to make it more general, I'm concerned we're actually creating a perf pit of failure.