Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit a diagnostic when encountering JsonConverterAttribute annotations with inaccessible converter type constructors. #87140

Closed
Tracked by #77019
eiriktsarpalis opened this issue Jun 5, 2023 · 1 comment · Fixed by #87796
Closed
Tracked by #77019

Emit a diagnostic when encountering JsonConverterAttribute annotations with inaccessible converter type constructors. #87140

eiriktsarpalis opened this issue Jun 5, 2023 · 1 comment · Fixed by #87796
Assignees
@eiriktsarpalis
Labels
area-System.Text.Json source-generator Indicates an issue with a source generator feature
Milestone
8.0.0

Comments

@eiriktsarpalis
Copy link
Member 

          Re https://github.com/dotnet/runtime/issues/81702#issuecomment-1577321673: we don't appear to issue a diagnostic when there's a the attribute specifies a converter that we can't access or instantiate. Should we?

Originally posted by @layomia in #87136 (comment)
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 5, 2023
@ghost
Copy link

ghost commented Jun 5, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details 
          Re https://github.com/dotnet/runtime/issues/81702#issuecomment-1577321673: we don't appear to issue a diagnostic when there's a the attribute specifies a converter that we can't access or instantiate. Should we?

Originally posted by @layomia in #87136 (comment)

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json, untriaged
Milestone: -

@eiriktsarpalis eiriktsarpalis self-assigned this Jun 5, 2023
@eiriktsarpalis eiriktsarpalis removed the untriaged New issue has not been triaged by the area owner label Jun 5, 2023
@eiriktsarpalis eiriktsarpalis added this to the 8.0.0 milestone Jun 5, 2023
@eiriktsarpalis eiriktsarpalis added the source-generator Indicates an issue with a source generator feature label Jun 5, 2023
This was referenced Jun 5, 2023
Merged
Closed
@eiriktsarpalis eiriktsarpalis changed the title Emit a diagnostic when encountering JsonConverAttribute annotations with inaccessible converter type constructors. Emit a diagnostic when encountering JsonConverterAttribute annotations with inaccessible converter type constructors. Jun 15, 2023
This was referenced Jun 15, 2023
Closed
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jun 20, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jun 20, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Fix a number of source generator bugs. eiriktsarpalis/runtime
1 participant
@eiriktsarpalis