-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor build scripts to have common code in a common script file #9179
Comments
cc: @eerhardt |
This same is true for cmd scripts: build.cmd, build-test.cmd, run.cmd, init-tools.cmd and tests\runtest.cmd all have duplicated functionality. Perhaps it would be good to do the same for windows scripts as well. |
FWIW, CoreRT solved this problem by having the common setup in https://github.com/dotnet/corert/blob/master/buildscripts/buildvars-setup.cmd and https://github.com/dotnet/corert/blob/master/buildscripts/buildvars-setup.sh; and calling this script as the first thing from the main script. |
Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process. This process is part of our issue cleanup automation. |
This issue will now be closed since it had been marked |
Currently, the build.sh, init-tools.sh, build-packages.sh and build-test.sh contains copies of the same code e.g. for host rid detection. We should move the shared code to a shared shell script file so that we have just one copy of that code.
Later on, it would be ideal to share that code even between all of our repos.
The text was updated successfully, but these errors were encountered: