Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename dns.lookupS.duration to dns.lookup.duration #92917

Closed
antonfirsov opened this issue Oct 3, 2023 · 2 comments
Closed

Rename dns.lookupS.duration to dns.lookup.duration #92917

antonfirsov opened this issue Oct 3, 2023 · 2 comments
Assignees
@antonfirsov
Labels
area-System.Net
Milestone
8.0.0

Comments

@antonfirsov
Copy link
Member

The name implemented in #89813 is result of a misunderstanding. https://github.com/lmolkova/semantic-conventions/blob/dotnet8-metrics/docs/dotnet/dotnet-dns-metrics.md#metric-dnslookupsduration has a typo in the title, but lower in the table it's correctly spelled as dns.lookup.duration which is a name that aligns with OTel conventions.
@antonfirsov antonfirsov added this to the 8.0.0 milestone Oct 3, 2023
@ghost
Copy link

ghost commented Oct 3, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

The name implemented in #89813 is result of a misunderstanding. https://github.com/lmolkova/semantic-conventions/blob/dotnet8-metrics/docs/dotnet/dotnet-dns-metrics.md#metric-dnslookupsduration has a typo in the title, but lower in the table it's correctly spelled as dns.lookup.duration which is a name that aligns with OTel conventions.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net
Milestone: 8.0.0

This was referenced Oct 9, 2023
Merged
Merged
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Oct 12, 2023
@antonfirsov
Copy link
Member Author

antonfirsov commented Oct 16, 2023 •
edited by karelz
Loading

Fixed by #93414 in release/8.0, and by #93254 in main (9.0).

@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@antonfirsov antonfirsov

Labels
area-System.Net
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
1 participant
@antonfirsov